Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI usage for pki.py and update Makefile #254

Merged
merged 6 commits into from
Jan 7, 2020
Merged

Add CLI usage for pki.py and update Makefile #254

merged 6 commits into from
Jan 7, 2020

Conversation

abhinavsingh
Copy link
Owner

See #234 and #251 for background

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #254 into develop will decrease coverage by 0.61%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
- Coverage    73.45%   72.84%   -0.62%     
===========================================
  Files           70       70              
  Lines         2788     2817      +29     
===========================================
+ Hits          2048     2052       +4     
- Misses         740      765      +25
Impacted Files Coverage Δ
proxy/common/version.py 100% <100%> (ø) ⬆️
proxy/common/pki.py 69.14% <13.79%> (-24.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067664e...6c19268. Read the comment docs.

@abhinavsingh
Copy link
Owner Author

jFYI @JohnnySheppard @Benouare

@abhinavsingh
Copy link
Owner Author

@JohnnySheppard @Benouare

I updated Makefile to use pki.py now, can you folks give it a try and verify. Thank you!!!

@abhinavsingh
Copy link
Owner Author

@abhinavsingh abhinavsingh merged commit ac29e34 into develop Jan 7, 2020
@abhinavsingh abhinavsingh deleted the pki branch January 7, 2020 03:51
@JohnnySheppard
Copy link

@JohnnySheppard @Benouare

I updated Makefile to use pki.py now, can you folks give it a try and verify. Thank you!!!

Thanks for sorting this so quickly. I'll try it as soon as I can (which will probably be Wednesday evening).

Thanks again.

@Benouare
Copy link
Contributor

Benouare commented Jan 7, 2020

Just tried it, and it works.
Still have the issue with the OSError when wrapping client / SEC_ERROR_REUSED_ISSUER_AND_SERIAL, but its working better than using certs generated by the "classic" openssl calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants