bugfix when loading plugins

[normal-cock]

The reason why except HttpProtocolException as e doesn't work as expected is that the way we load plugin in proxy.py is improper. We should not import a module itself in it, instead try to use importlib.import_module("__main__").

For example, suppose we have a test2.py the content of which is as following. The result of the code is False, and that's why except HttpProtocolException as e doesn't work.

# test2.py
class A:
    pass

from test2 import A as B

if __name__ == "__main__":
    print(A==B)
    exit(0)

[abhinavsingh]

@normal-cock Awesome. Makes sense, this is much better. But why have you deleted python-package.yml in the PR?

[normal-cock]

@normal-cock Awesome. Makes sense, this is much better. But why have you deleted python-package.yml in the PR?

@abhinavsingh I remove python-package.yml because I don't think it should be a part of the project itself. Most importantly, the file makes me unable to push a new branch to my own github repository :( . I think it's better to delete python-package.yml in repository and keep it local by adding it in .gitignore. Wdyt?

[abhinavsingh]

@normal-cock python-package.yml belongs to GitHub CI/CD integration, it's similar to .travis.yml file in the repository. python-package.yml is part of GitHub actions which results in CI/CD run for every commit and PR. See https://github.com/abhinavsingh/proxy.py/actions

I am not sure but do you have to enable actions for your account? GitHub actions is relatively new and unsure if it's available for all, but no reason why you can't check into your repository. What errors do you get when you try to commit to your repo?

[normal-cock]

@abhinavsingh The error message when I keep python-package.yml is that:

! [remote rejected] develop2 -> develop2 (refusing to allow an integration to create or update .github/workflows/python-package.yml)

[abhinavsingh]

@abhinavsingh The error message when I keep python-package.yml is that:

! [remote rejected] develop2 -> develop2 (refusing to allow an integration to create or update .github/workflows/python-package.yml)

Signup for actions here https://github.com/features/actions and try again. Github actions is a new feature from Github, its surprising that they are refusing you to push into repo. My guess is since you don't have actions enabled, you are unable to push.

Can you try and let me know. Thanks

[normal-cock]

I've enable actions and the error is still there. @abhinavsingh

[abhinavsingh]

Reading the error message again refusing to allow an integration to create or update, looks like you cannot create or update existing Github action, unsure how you ended up deleting it in first place then :)

My guess is, start in a new branch which still contains .github/workflows folder, un-edited. Then you should be able to push your edits for other files. Can you try and confirm? Will try to also raise this with Github, doesn't sound right to me.

[normal-cock]

start in a new branch which still contains .github/workflows folder, un-edited. Then you should be able to push your edits for other files.

@abhinavsingh The error is unchanged.

The phenomena is that only if I delete .github/workflows in git, can I push new branch to my repository. That's strange.

[normal-cock]

It seems that some has raise this with Github https://github.community/t5/GitHub-Actions/Refusing-to-allow-an-integration-to-create-or-update/td-p/32472.

[abhinavsingh]

Thanks for the find. From that thread:

Is there any solution to this? Forcing the contributors to use SSH is not an option.

Did you close using git clone https://github.com/abhinavsingh/proxy.py.git or git clone git@github.com:abhinavsingh/proxy.py.git. Does the later one help you to push? This is indeed annoying from Github.

[normal-cock]

@abhinavsingh Cool, it works after I change my origin from https://github.com/normal-cock/proxy.py.git to git@github.com:normal-cock/proxy.py.git

[normal-cock]

I've change the pr. @abhinavsingh

[abhinavsingh]

I've change the pr. @abhinavsingh

Awesome, can you make sure tests are passing. I haven't used importlib.import_module('__main__') myself before and want to make sure it works as expected. Thank you.

[abhinavsingh]

Kindly Squash and merge. Thank you. LGTM.