Adds TXT transcript, --format option, handle input with special chars #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an bug introduced in a prior commit where the line_count increment logic changed and the line_count no longer begins at 1 as intended.
Reduces duplication by moving the code used to generate of the SRT/VTT timestamp strings used for each subtitle to its own function. Reducing the unnecessary duplication reduces the risk of errors being introduced. Ref abhirooptalasila#33
Replaces the --vtt argument that is used to switch between creating an SRT file or a VTT file, to instead always create both formats by default and allow the user to specify a subset of formats using the --format argument introduced in this commit. As discussed in abhirooptalasila#33, it is the inference part that takes the bulk of the execution time and the output subtitle file format doesn't take much time and uses very little disk space then rerunning the entire inference again just to get a VTT file is inefficient, so it makes more sense just to create the VTT and SRT by default. Fixes abhirooptalasila#33
Adds the ability to create text file containing a simple transcript of inferred audio, in addition to the subtitle file formats.
Improves the handling of filenames which contain special characters by not processing the ffmpeg command using a shell, and passing the arguments in using a Python list. Note: The use of the old 'subprocess.call()' API here is unchanged. A future commit may switch to the more modern subprocess.run().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See constituent commits.
Fixes #33