Use "AbsoluteUri" instead of "ToString()" to avoid removing the escap…

…ing from query string parameters.
abhishekbhalani · May 17, 2011 · c59af2e · c59af2e
1 parent 16c9aed
commit c59af2e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Mvc.Mailer.Test/ExtensionMethods/UrlHelperExtensionsTest.cs b/Mvc.Mailer.Test/ExtensionMethods/UrlHelperExtensionsTest.cs
@@ -53,6 +53,12 @@ public void Abs_with_root_should_absolutilze()
             Assert.AreEqual("http://example.com:8080/", _urlHelper.Abs("/"));
         }
 
+        [Test]
+        public void Abs_with_encoded_params_should_keep_encoding()
+        {
+            Assert.AreEqual("http://example.com:8080/?param=encoded%20value", _urlHelper.Abs("/?param=encoded%20value"));
+        }
+
         [Test]
         public void Abs_with_config_should_use_the_base_url_from_the_config()
         {

diff --git a/Mvc.Mailer/ExtensionMethods/UrlHelperExtensions.cs b/Mvc.Mailer/ExtensionMethods/UrlHelperExtensions.cs
@@ -26,7 +26,7 @@ public static string Abs(this UrlHelper urlHelper, string relativeOrAbsoluteUrl)
             Uri combinedUri;
             if (Uri.TryCreate(BaseUrl(urlHelper), relativeOrAbsoluteUrl, out combinedUri))
             {
-                return combinedUri.ToString();
+                return combinedUri.AbsoluteUri;
             }
 
             throw new Exception(string.Format("Could not create absolute url for {0} using baseUri{0}", relativeOrAbsoluteUrl, BaseUrl(urlHelper)));