Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA implemented #21

Merged
merged 1 commit into from Oct 10, 2020
Merged

PWA implemented #21

merged 1 commit into from Oct 10, 2020

Conversation

Satyam1203
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Motivation

I have worked in single page applications and PWA provides native like features, so I found this issue matching what I can do.

Related PRs and Issues

#2 PWA Implementation Done.

@vercel
Copy link

vercel bot commented Oct 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/abhisheknaiidu/a-pop/jx0ch42qn
✅ Preview: https://a-pop-git-fork-satyam1203-master.abhisheknaiidu.vercel.app

Copy link
Owner

@abhisheknaiidu abhisheknaiidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Satyam1203 Nice Work, But I don't know why the thumbnails are not loading after refreshing the page again, neither it's showing the A-POP dialog for PWA

@Satyam1203
Copy link
Contributor Author

@abhisheknaiidu Do you mean that "Add to home screen" Dialog?

@abhisheknaiidu
Copy link
Owner

@abhisheknaiidu Do you mean that "Add to home screen" Dialog?

Yup, I mean the same. It just came at first when I opened the changes in the mobile browser, but after that it never came.

@Satyam1203
Copy link
Contributor Author

@abhisheknaiidu Do you mean that "Add to home screen" Dialog?

Yup, I mean the same. It just came at first when I opened the changes in the mobile browser, but after that it never came.

I tried just once and it gave me a pop-up saying "Add to home screen", I didn't try it more than once... Don't know why is it not appearing again.

I read this answer, https://stackoverflow.com/questions/44255285/add-to-home-screen-prompt-doesnt-show-up-again-if-tab-is-closed/44712586 which says if you dismissed one, it doesn't reappear until you clear cache for that site.

@abhisheknaiidu
Copy link
Owner

@Satyam1203 Yea because of caches it might be not showing, but

  • It should show in Incognito Mode, neither it's showing there nw
  • Also the Images are not loading in the app after I install PWA

@Satyam1203
Copy link
Contributor Author

I'll see if I can make it work. @abhisheknaiidu

@abhisheknaiidu
Copy link
Owner

I'll see if I can make it work. @abhisheknaiidu

Sure, if you've any doubts and want to connect with other fellow awesome developers, you can join us on discord https://discord.gg/WHGhXvW

@abhisheknaiidu abhisheknaiidu merged commit 7b6d06d into abhisheknaiidu:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants