Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GOFILE env var #141

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Use GOFILE env var #141

merged 2 commits into from
Nov 8, 2022

Conversation

angaz
Copy link
Contributor

@angaz angaz commented Oct 9, 2022

Adds GOFILE env var to the CLI config so that the file flag not required when using //go:generate.

@angaz angaz requested a review from abice as a code owner October 9, 2022 14:59
@angaz angaz changed the title Use gofile env var Use GOFILE env var Oct 9, 2022
@angaz angaz changed the title Use GOFILE env var Use GOFILE env var Oct 9, 2022
@abice
Copy link
Owner

abice commented Oct 16, 2022

Hey, sorry for not responding to this yet, I've been rather busy.

I definitely like this change, but I want to test it locally to ensure it works (docs say it does, but I gotta verify myself). As soon as I get time, I'll check it out and likely merge.

Thanks for the contribution!

Copy link
Owner

@abice abice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update from master, so that the branch isn't out of date, and I'll merge it.

Thanks for the contribution!

@abice abice merged commit 003d279 into abice:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants