Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade twine to resolve issue with importlib-metadata #39

Merged

Conversation

kimberninger
Copy link
Contributor

@kimberninger kimberninger commented Jun 27, 2024

This pull request addresses a bug stemming from twine's reliance on deprecated behavior, which was removed from importlib-metadata in version 8.0.0.

The plugin currently uses twine version 4.0.2, which depends on the latest version of importlib-metadata (>= 3.6).
Consequently, it is impacted by the breaking changes introduced in importlib-metadata version 8.0.0.

This issue has been resolved in twine version 5.1.1.

@kimberninger kimberninger force-pushed the fix-twine-importlib-metadata branch 2 times, most recently from 81eb418 to 19cb027 Compare June 27, 2024 13:18
Update twine to version 5.1.1 or higher to address a bug stemming from
twine's reliance on deprecated behavior, which was removed from
importlib-metadata in version 8.0.0.
For more details, see:
- python/importlib_metadata@a970a49
- pypa/twine#977

The plugin currently uses twine version 4.0.2, which depends on the
latest version of importlib-metadata (>= 3.6).
Consequently, it is impacted by the breaking changes introduced in
importlib-metadata version 8.0.0.

This issue has been resolved in twine version 5.1.1, as detailed here:
pypa/twine#1124.
@ignacio-kognitos
Copy link

Thanks for this PR, I'm stuck with the same issue and came to the same conclusion. Hope this goes in fast!

@abichinger abichinger merged commit 320c019 into abichinger:main Jun 27, 2024
4 checks passed
@abichinger
Copy link
Owner

Thanks! LGTM

@abichinger
Copy link
Owner

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kimberninger kimberninger deleted the fix-twine-importlib-metadata branch June 27, 2024 19:55
davidbrownell added a commit to davidbrownell/dbrownell_DevTools that referenced this pull request Jul 2, 2024
davidbrownell added a commit to davidbrownell/AutoGitSemVer that referenced this pull request Jul 2, 2024
davidbrownell added a commit to davidbrownell/dbrownell_Common that referenced this pull request Jul 2, 2024
davidbrownell added a commit to davidbrownell/FileBackup that referenced this pull request Jul 2, 2024
davidbrownell added a commit to davidbrownell/SimpleSchemaGenerator that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants