Fix variable assignment problem with face detection example, and broken links. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an error with the face detection example in the Python tutorials. It currently assigns the result of a `cv2.rectangle()` call to the variable `img`, which is supposed to contain the image. The `cv2.rectangle()` call does not return anything, so `img` is null, so the subsequent assignment of `roi_color` fails. This fixes the problem by eliminating the variable assignment.
charlesreid1
changed the title
|
Repo/tutorials are longer maintained so abandoning this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an error with this face detection example in the OpenCV2 Python
tutorials. It currently assigns the result of a
cv2.rectangle()callto the variable
img, which is supposed to contain theimage. The
cv2.rectangle()call does not return anything,so
imgis null, so the subsequent assignment ofroi_colorfails.This fixes the problem by eliminating the variable assignment.