Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify script #7

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Simplify script #7

merged 1 commit into from
Feb 25, 2022

Conversation

mowtschan
Copy link
Contributor

This PR simplifies the script, there is no need to use azure.identity and azure.mgmt.resource at all.

This PR should also fix DeepSource issues:
image

@abij
Copy link
Owner

abij commented Feb 25, 2022

I was testing script and was already wondering why the AzureCLI needed to be login. Why there was an online check at all. It makes sense to check upfront. There could be new/more/different subscriptions, but after the switch it's not needed anymore. Nice, I'll check it out.

@abij abij merged commit bbc54fd into abij:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants