Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module json2: allow to call another search method #38

Merged
merged 7 commits into from May 3, 2017

Conversation

vindarel
Copy link
Contributor

@vindarel vindarel commented May 3, 2017

this is an api endpoint (Module.json2) that searches with a regular
database query (not Whoosh). Some modules may want to have their own
search method (so as to add bonus information into the text results for
example), so we call it if any or we rely on the basic
search (name.ilike).

this is an api endpoint (Module.json2) that searches with a regular
database query (not Whoosh). Some modules may want to have there own
search method (so as to add bonus information into the text results for
example), so we call it if any or we rely on the basic
search (name.ilike).
@codecov-io
Copy link

codecov-io commented May 3, 2017

Codecov Report

Merging #38 into master will decrease coverage by <.01%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage    63.6%   63.59%   -0.01%     
==========================================
  Files         136      136              
  Lines       12044    12054      +10     
==========================================
+ Hits         7660     7666       +6     
- Misses       4384     4388       +4
Impacted Files Coverage Δ
abilian/web/frontend.py 66.51% <18.18%> (-0.32%) ⬇️
abilian/web/views/object.py 35.52% <0%> (-0.11%) ⬇️
abilian/web/tags/admin.py 34.59% <0%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7e2fb...e0d27b1. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 63.59% when pulling 1b49689 on json2-search-method into 4f7e2fb on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 63.59% when pulling 1b49689 on json2-search-method into 4f7e2fb on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 63.598% when pulling 5efd2b7 on json2-search-method into 4f7e2fb on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 63.598% when pulling 5efd2b7 on json2-search-method into 4f7e2fb on master.

@coveralls
Copy link

coveralls commented May 3, 2017

Coverage Status

Coverage decreased (-0.002%) to 63.598% when pulling 5efd2b7 on json2-search-method into 4f7e2fb on master.

@coveralls
Copy link

coveralls commented May 3, 2017

Coverage Status

Coverage decreased (-0.005%) to 63.596% when pulling 2f3630f on json2-search-method into 4f7e2fb on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 63.59% when pulling e0d27b1 on json2-search-method into 4f7e2fb on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 63.59% when pulling e0d27b1 on json2-search-method into 4f7e2fb on master.

@sfermigier sfermigier merged commit fbebfa3 into master May 3, 2017
@vindarel vindarel deleted the json2-search-method branch May 4, 2017 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants