-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module json2: allow to call another search method #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is an api endpoint (Module.json2) that searches with a regular database query (not Whoosh). Some modules may want to have there own search method (so as to add bonus information into the text results for example), so we call it if any or we rely on the basic search (name.ilike).
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 63.6% 63.59% -0.01%
==========================================
Files 136 136
Lines 12044 12054 +10
==========================================
+ Hits 7660 7666 +6
- Misses 4384 4388 +4
Continue to review full report at Codecov.
|
1 similar comment
1 similar comment
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an api endpoint (Module.json2) that searches with a regular
database query (not Whoosh). Some modules may want to have their own
search method (so as to add bonus information into the text results for
example), so we call it if any or we rely on the basic
search (name.ilike).