Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreliable sshfs bind mount - directories/files gradually appear after container start #99

Closed
rfay opened this issue Jan 2, 2022 · 4 comments

Comments

@rfay
Copy link
Contributor

rfay commented Jan 2, 2022

I note that after a container start, directories that already existed and were bind-mounted may gradually appear after the container start. I imagine this is due to using the sshfs bind-mount, and sshfs isn't completed before container start. Is there a way to force sshfs flush before bringing up a container with a bind-mount?

I'll work on a repro scenario, but I wanted to point this out. It showed up in a ddev test which used bind-mount and worked consistently on docker for mac (and everywhere else).

@rfay
Copy link
Contributor Author

rfay commented Jan 9, 2022

rfay added a commit to rfay/lima that referenced this issue Jan 9, 2022
Signed-off-by: Randy Fay <randy@randyfay.com>
@abiosoft
Copy link
Owner

@rfay thanks for submitting the PR upstream.

AkihiroSuda added a commit to lima-vm/lima that referenced this issue Jan 11, 2022
@abiosoft
Copy link
Owner

This has been merged upstream and should be fixed now. Can you kindly update lima and try again?

@rfay
Copy link
Contributor Author

rfay commented Jan 13, 2022

With updated colima/lima I see the correct
ssh -F /dev/null -o IdentityFile="/Users/rfay/.lima/_config/user" -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o NoHostAuthenticationForLocalhost=yes -o GSSAPIAuthentication=no -o PreferredAuthentications=publickey -o Compression=no -o BatchMode=yes -o IdentitiesOnly=yes -o Ciphers="^aes128-gcm@openssh.com,aes256-gcm@openssh.com" -o User=rfay -o ControlMaster=auto -o ControlPath="/Users/rfay/.lima/colima/ssh.sock" -o ControlPersist=5m -p 61506 127.0.0.1 -- sshfs :/tmp/colima /tmp/colima -o slave -o allow_other,cache=no

And the ddev test that persistently demonstrated the problem runs cleanly now.

Thanks!

@rfay rfay closed this as completed Jan 13, 2022
rfay added a commit to rfay/lima that referenced this issue Jan 15, 2022
This reverts commit b80a4d2.

Signed-off-by: Randy Fay <randy@randyfay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants