Add GolangCI Lint

[kensipe]

• Adding GolangCI Lint for linting
• Added lint task to Makefile
• Resolved basic linting issues

Lint Resolution

• Removed kubernetesVersion as it is private and used. If desired, please indicate how it is to be used
• time.Since is preferred to time.Now().Sub otherwise same functionality
• Likely the most controversial, The assignment of downloadURL := u was never used. if err not nil, it is assigned to u otherwise an error is returned. It is better and more readable in Go to not use else unless required, in this case, it is much more clear.

Looking forward to adding more linting rules. I was looking for feedback on this first.

Signed-off-by: Ken Sipe <kensipe@gmail.com

[kensipe]

@abiosoft any thoughts? or help regarding Linting?

[abiosoft]

@kensipe I was working on the codebase at the time and would rather not deal with conflicts.
You can rebase now and I'll have a look afterwards.

Thanks.

[kensipe]

@abiosoft rebase complete.. no merge conflicts to resolve

[kensipe]

it's worth noting but perhaps obvious... the first lint requires connectivity to pull the versioned linter. All other lints can work with a disconnected machine.

[kensipe]

@abiosoft ok. Add adjustments made. Worth noting that this is the initial stage. The config file is empty making this PR small. I was planning on adding a number of linters for your review after this is merged.

As noted, I still have concerns over linter versioning but happy to seeing linting

As note that based on guidance, there is a total assumption the linter is in the path. The result of it not being in the path is:

make lint
golangci-lint --timeout 3m run
make: golangci-lint: No such file or directory
make: *** [lint] Error 1

[abiosoft]

One last thing to make this actually be part of the CI, can you add a lint step as part of the build job in .github/workflows/go.yml?

[abiosoft]

As note that based on guidance, there is a total assumption the linter is in the path. The result of it not being in the path is:

make lint
golangci-lint --timeout 3m run
make: golangci-lint: No such file or directory
make: *** [lint] Error 1

Not an issue, it will be available in the CI environment. And anyone that wants to run it locally can always install it.

[kensipe]

@abiosoft ✅