docker: allow specifying version and channel to install #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abiosoft
reviewed
Nov 19, 2023
crazy-max
force-pushed
the
docker-version
branch
from
e15770f
to
a224e24
Compare
crazy-max
force-pushed
the
docker-version
branch
from
a224e24
to
7c56739
Compare
abiosoft
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I would need to specify the docker version/channel to install. This is related to a GitHub Action I maintain https://github.com/crazy-max/ghaction-setup-docker and specially crazy-max/ghaction-setup-docker#47.
With this change, user can set
DOCKER_INSTALL_VERSIONandDOCKER_INSTALL_CHANNELto install a specific version. This also returns the rightpkgFilesbased on the selected channel.