Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bold versions of check and close icons #2

Merged
merged 5 commits into from
Jun 12, 2020
Merged

Add bold versions of check and close icons #2

merged 5 commits into from
Jun 12, 2020

Conversation

alfonsomelloc
Copy link
Contributor

No description provided.

@alfonsomelloc
Add bold versions of Check and Close icons
02b5a11 
- Also update `#000` to `currentColor` on Bookmark icon
@alfonsomelloc
1.10.0
a427b96
@alfonsomelloc alfonsomelloc self-assigned this Jun 11, 2020
sergiodxa
sergiodxa reviewed Jun 11, 2020
View reviewed changes
Copy link
Contributor

@sergiodxa sergiodxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot adding className={className} to the SVG tags

package.json Outdated Show resolved Hide resolved
@alfonsomelloc
Add className = {className} to svg tag
4570ae3 
- Also matched width, height, viewbox with to the rest of the icons.
@alfonsomelloc
Revert "1.10.0"
48accd1 
This reverts commit a427b96.
@alfonsomelloc alfonsomelloc merged commit 528407e into master Jun 12, 2020
@alfonsomelloc alfonsomelloc deleted the add-check-close-bold branch June 12, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodxa sergiodxa sergiodxa approved these changes

Assignees

@alfonsomelloc alfonsomelloc

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alfonsomelloc @sergiodxa