Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDU-805] Updates and refactoring (& Gardening) #10

Merged
merged 24 commits into from
Oct 7, 2022
Merged

[EDU-805] Updates and refactoring (& Gardening) #10

merged 24 commits into from
Oct 7, 2022

Conversation

fliptopbox
Copy link
Contributor

@fliptopbox fliptopbox commented Mar 28, 2022 •
edited
Loading

important

This PR has been extended to accommodate the changes required by EDU-805

  • Replace in README all TLD .io with .com
  • Replace remote assets with local assets (ie. images in the readme)
  • Update the tutorial md with .com TLD
  • Replace bitmap banner with HTML banner w. static assets logo (CSS added to index.html header)
  • correct all instancing pattern with the (new) keyword

@fliptopbox fliptopbox self-assigned this Mar 28, 2022
@fliptopbox fliptopbox changed the title Gardening [EDU-805] Updates and refactoring (& Gardening) Jun 22, 2022
Bruce Thomas and others added 17 commits June 23, 2022 11:03
Add new key word
d9889c0
Replace IO with COM
794037e
Download remote illustrations
48fdb19
Update readme with locally hosted assets
331ccb9
replace .io with .com URLs
8113a3b
Updated header and package.json
b381aeb 
- Replaced bitmap header with editable HTML header + static asset logo
- bumped the package json version
- added static CSS for header styling to HTML head
Rendered the static rendered assets (vue build)
b9810db
Vue static render (build artefacts)
c80b24a
Added the version minimiums
7af2de5
Added example env file
2c2f3e7
Refactor: changed question.js to json
95068fa
Audit: updated NPM packages
3aa5bc9
Update: added example env, replaced .io URLs
0057498
Added reference to .env.example
0e18790
@fliptopbox
Updated the static README assets
2594064 
- updated embeded Ably logo screenshot
- updated 2 illustartions (as used in the related PDF)
@fliptopbox
Fix incorrect folder name
51126b7
@fliptopbox
Update TUTORIAL with corrent instancing (new)
684f320
marcduiker
marcduiker reviewed Aug 16, 2022
View reviewed changes
TUTORIAL.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@fliptopbox fliptopbox added enhancement New feature or request maintenance General code updates and maintenance chores labels Aug 16, 2022
marcduiker
marcduiker approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fliptopbox fliptopbox merged commit 9ebb755 into main Oct 7, 2022
@fliptopbox fliptopbox deleted the gardening branch October 7, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcduiker marcduiker marcduiker approved these changes

Assignees

@fliptopbox fliptopbox

Labels
enhancement New feature or request maintenance General code updates and maintenance chores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fliptopbox @marcduiker