Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the NetworkConnectivityTests to use sdk-test-proxy #1003

Closed
7 tasks done
lawrence-forooghian opened this issue Feb 14, 2023 · 1 comment · Fixed by #1012
Closed
7 tasks done

Update the NetworkConnectivityTests to use sdk-test-proxy #1003

lawrence-forooghian opened this issue Feb 14, 2023 · 1 comment · Fixed by #1012
Assignees
@lawrence-forooghian

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Feb 14, 2023 •
edited
Loading

I’ve created a standalone server in https://github.com/ably/sdk-test-proxy which contains all of the fault proxy code that’s currently being used by AAT Android’s NetworkConnectivityTests. I want to remove the proxy code from AAT Android and update it to instead use this standalone server.

First of all I want to address these outstanding issues for the proxy:

Branch use-external-proxy-for-NetworkConnectivityTests in this repo has been updated to use the external server. All of the NetworkConnectivityTests are passing on this branch.

The remaining work to do is the following:

  • Tidy up the updated code on that branch (make sure docstrings are still correct)
  • Add proxy as a submodule so that we can lock its version
  • Add instructions for running proxy locally
  • Fix CI build (i.e. run proxy in CI)
  • Update the test skipping mechanism
  • Integrate with Subscriber Connectivity Tests #924 once that’s merged
  • Check if Android version limitations still apply
@lawrence-forooghian lawrence-forooghian self-assigned this Feb 14, 2023
@lawrence-forooghian lawrence-forooghian mentioned this issue Feb 14, 2023
Closed
@sync-by-unito
Copy link

sync-by-unito bot commented Feb 14, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3345

This was referenced Feb 14, 2023
Closed
Open
lawrence-forooghian added a commit that referenced this issue Feb 16, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
5c2c2ee 
Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 16, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
fa1eaa8 
Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 16, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
f887ec6 
TODO which of the workflows are we meant to be running the server on?
TODO can we decrease the 1m 35s this takes to start?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 16, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
fd4b615 
TODO can we decrease the 1m 35s this takes to start?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 16, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
e375322 
TODO can we decrease the 1m 35s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 16, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
460521e 
TODO can we decrease the 1m 35s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 16, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
2501fa4 
TODO can we decrease the 1m 35s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 16, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
43168f0 
TODO can we decrease the 1m 35s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 16, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
09a4db5 
TODO can we decrease the 1m 55s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 20, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
9c11ac1 
TODO can we decrease the 1m 55s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?
TODO don't run if we’re not going to run NetworkConnectivityTests? or do the version limitations not apply any more?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 20, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
e707251 
TODO can we decrease the 1m 55s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?
TODO don't run if we’re not going to run NetworkConnectivityTests? or do the version limitations not apply any more?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 20, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
a7f1b26 
TODO can we decrease the 1m 55s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?
TODO don't run if we’re not going to run NetworkConnectivityTests?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 20, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
587cc30 
TODO can we decrease the 1m 55s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?
TODO don't run if we’re not going to run NetworkConnectivityTests?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 20, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
639b1e1 
TODO can we decrease the 1m 55s this takes to start?
TODO can we reduce the risk of one test case or test run contaminating another?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 20, 2023
@lawrence-forooghian
WIP integration with sdk-test-proxy
74c8127 
TODO can we decrease the 1m 55s this takes to start?

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 20, 2023
@lawrence-forooghian
Replace in-process NetworkConnectivityTests proxy with external
c06c5a6 
This replaces the in-process proxy with an external proxy that runs on the
machine that hosts the Android emulator. We’re doing this so that the proxy
code can be reused for the Swift Asset Tracking SDKs.

Resolves #1003.
lawrence-forooghian added a commit that referenced this issue Feb 20, 2023
@lawrence-forooghian
Replace in-process NetworkConnectivityTests proxy with external
d2513a0 
This replaces the in-process proxy with an external proxy that runs on the
machine that hosts the Android emulator. We’re doing this so that the proxy
code can be reused for the Swift Asset Tracking SDKs.

Resolves #1003.
@lawrence-forooghian lawrence-forooghian mentioned this issue Feb 20, 2023
Open
lawrence-forooghian added a commit that referenced this issue Feb 20, 2023
@lawrence-forooghian
Replace in-process NetworkConnectivityTests proxy with external
29ad8c0 
This replaces the in-process proxy with an external proxy that runs on the
machine that hosts the Android emulator. We’re doing this so that the proxy
code can be reused for the Swift Asset Tracking SDKs.

Resolves #1003.
@lawrence-forooghian lawrence-forooghian mentioned this issue Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
None yet
Milestone
No milestone
1 participant
@lawrence-forooghian