Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldNotEmitPublisherPresenceFalseIfPublisherIsPresentFromTheStart (PublisherAndSubscriberTests) failing with "first publisherPresence value should be true" #845

Closed
QuintinWillison opened this issue Dec 14, 2022 · 4 comments · Fixed by #884
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Dec 14, 2022

I've only seen one failure so far for this test, but am creating an issue so we can track it.

Failing from our Android emulation workflow. This link will only survive as long as GitHub keeps the test run logs, so I'll also quote from the output...

At API Level 24 (#842):

com.ably.tracking.tests.PublisherAndSubscriberTests > shouldNotEmitPublisherPresenceFalseIfPublisherIsPresentFromTheStart[test(AVD) - 7.0] FAILED 
	java.lang.AssertionError: first publisherPresence value should be true
	at org.junit.Assert.fail(Assert.java:89)
@QuintinWillison QuintinWillison added the failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. label Dec 14, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 14, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3183

@QuintinWillison
Copy link
Contributor Author

At API Level 21 (#856):

com.ably.tracking.tests.PublisherAndSubscriberTests > shouldNotEmitPublisherPresenceFalseIfPublisherIsPresentFromTheStart[test(AVD) - 5.0.2] FAILED 
	java.lang.AssertionError: first publisherPresence value should be true
	at org.junit.Assert.fail(Assert.java:89)

@QuintinWillison
Copy link
Contributor Author

QuintinWillison commented Jan 5, 2023

At API Level 21 (#877):

com.ably.tracking.tests.PublisherAndSubscriberTests > shouldNotEmitPublisherPresenceFalseIfPublisherIsPresentFromTheStart[test(AVD) - 5.0.2] FAILED 
	java.lang.AssertionError: first publisherPresence value should be true
	at org.junit.Assert.fail(Assert.java:89)
Tests on test(AVD) - 5.0.2 failed: There was 1 failure(s).

> Task :integration-testing-app:connectedDebugAndroidTest FAILED

@QuintinWillison
Copy link
Contributor Author

While working locally on #259 I had this test fail when I ran this group of tests.

I used ./gradlew -Pandroid.testInstrumentationRunnerArguments.class=com.ably.tracking.tests.PublisherAndSubscriberTests :integration-testing-app:connectedDebugAndroidTest and got:

com.ably.tracking.tests.PublisherAndSubscriberTests > shouldNotEmitPublisherPresenceFalseIfPublisherIsPresentFromTheStart[Nexus_S_API_22(AVD) - 5.1.1] FAILED
        java.lang.AssertionError: first publisherPresence value should be true
        at org.junit.Assert.fail(Assert.java:89)
Tests on Nexus_S_API_22(AVD) - 5.1.1 failed: There was 1 failure(s).

> Task :integration-testing-app:connectedDebugAndroidTest FAILED

Where a bit more detail was present in the report:

java.lang.AssertionError: first publisherPresence value should be true
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at com.ably.tracking.tests.PublisherAndSubscriberTests.shouldNotEmitPublisherPresenceFalseIfPublisherIsPresentFromTheStart(PublisherAndSubscriberTests.kt:294)

at (git rev-parse HEAD): 3b15763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Development

Successfully merging a pull request may close this issue.

1 participant