Fix minor issue in the adhoc example app publishing workflow #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ORG_GRADLE_PROJECT_ prefix is used in our GitHub workflows as a means to convert an environment variable into a Gradle property, however the property name then strips that prefix.
QuintinWillison
requested review from
ikbalkaya,
AndyTWF,
davyskiba and
lawrence-forooghian
davyskiba
approved these changes
Feb 1, 2023
QuintinWillison
deleted the
fix-release-notes-context-for-adhoc-example-app-publish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove copy-pasted prefix from property name.
The
ORG_GRADLE_PROJECT_prefix is used in our GitHub workflows as a means to convert an environment variable into a Gradle property, however the property name then strips that prefix.I had correctly stripped it for
ABLY_BUILD_CONTEXT_BUILD_METADATAhere, injected here, but for some reason hadn't done the same forABLY_BUILD_CONTEXT_TITLE. This pull request fixes that oversight.