Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially insecure usage of the NSURLSession API #1079

Closed
QuintinWillison opened this issue Oct 13, 2020 · 2 comments · Fixed by #1120 or #1158
Closed

Potentially insecure usage of the NSURLSession API #1079

QuintinWillison opened this issue Oct 13, 2020 · 2 comments · Fixed by #1120 or #1158
Assignees
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Oct 13, 2020

We use NSURLSessionConfiguration's defaultSessionConfiguration singleton in ARTURLSessionServerTrust.m.

We should be using ephemeralSessionConfiguration instead as that "uses no persistent storage for caches, cookies, or credentials".

Additionally we should also be insisting on TLS protocol negotiation at a minimum of version 1.2. Possibly by using TLSMinimumSupportedProtocol, though that seems to have been deprecated and replaced with TLSMinimumSupportedProtocolVersion but we need to consider using that API cautiously when it comes to backwards compatibility.

When working on this issue please ensure to check other use of NSURLSession APIs as, for example, the sharedSession singleton is also problematic for the same reasons.

Also, for the purposes of breadcrumbs, see the question I asked in Slack to which paddybyers responded with:

all clients should insist on 1.2+

┆Issue is synchronized with this Jira Bug by Unito

@QuintinWillison QuintinWillison added the bug Something isn't working. It's clear that this does need to be fixed. label Oct 13, 2020
@SpencerWallsworth
Copy link

Is there an update on this bug or an expectation when this will be fixed?

@QuintinWillison
Copy link
Contributor Author

Hi @SpencerWallsworth - sorry for the (very slow!) response but I only just now noticed your comment when I was looking through issues. There is no precise timescale I can provide, however we are looking at ramping up development on this client library in the next couple of months and, as such, this issue is high on the backlog to be worked on then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
3 participants