Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK tests are not running on MacBook Pro M1 #1506

Closed
arturjaworski opened this issue Sep 27, 2022 · 0 comments · Fixed by #1510
Closed

SDK tests are not running on MacBook Pro M1 #1506

arturjaworski opened this issue Sep 27, 2022 · 0 comments · Fixed by #1510

Comments

@arturjaworski
Copy link

arturjaworski commented Sep 27, 2022

I was trying to test Ably Cocoa SDK as it's described in CONTRIBUTING.md which means I run:

make update
make test_iOS

The second command is failing. It looks like it's related to the ARM M1 processor in MacBook Pro. I was able to fix it by removing arm64 from Scripts/carthage-with-workaround-for-issue-3019.sh, line 14, but it needs to be confirmed that it's not affecting other issues.

Full output is:

aj:~/Development/ably-cocoa $ make update    
Updating submodules…
git submodule update --init --recursive
Updating Carthage dependencies for all platforms…
./Scripts/carthage-with-workaround-for-issue-3019.sh update --use-xcframeworks --no-use-binaries
*** Fetching Nimble
*** Fetching SwiftyJSON
*** Fetching msgpack-objective-C
*** Fetching delta-codec-cocoa
*** Checking out Nimble at "v9.2.1"
*** Checking out SwiftyJSON at "4.3.0"
*** Checking out msgpack-objective-C at "0.4.0"
*** Checking out Aspects at "1.4.2-ws1"
*** Checking out delta-codec-cocoa at "1.3.3"
*** xcodebuild output can be found in /var/folders/l7/k19sspgx3md0x34dwj_h525h0000gn/T/carthage-xcodebuild.AZvOZD.log
*** Building scheme "Aspects-Mac" in Aspects.xcodeproj
*** Building scheme "Aspects-tvOS" in Aspects.xcodeproj
Could not find any available simulators for tvOS
make: *** [update_carthage_dependencies] Error 1
aj:~/Development/ably-cocoa $ make test_iOS       
ABLY_ENV="sandbox" NAME="ably-iOS" bundle exec fastlane test_iOS14_4
[✔] 🚀 
[13:54:45]: ------------------------------
[13:54:45]: --- Step: default_platform ---
[13:54:45]: ------------------------------
[13:54:45]: Driving the lane 'ios test_iOS14_4' 🚀
[13:54:45]: -----------------------
[13:54:45]: --- Step: run_tests ---
[13:54:45]: -----------------------
[13:54:45]: Successfully loaded '/Users/aj/Development/ably-cocoa/fastlane/Scanfile' 📄

+----------------------+---------------------+
| Detected Values from './fastlane/Scanfile' |
+----------------------+---------------------+
| open_report          | false               |
| clean                | true                |
| skip_slack           | true                |
| ensure_devices_found | true                |
| output_types         | junit               |
| xcodebuild_formatter | xcbeautify          |
| result_bundle        | true                |
+----------------------+---------------------+

[13:54:45]: Resolving Swift Package Manager dependencies...
[13:54:45]: $ xcodebuild -resolvePackageDependencies -scheme Ably-iOS-Tests -project ./Ably.xcodeproj -derivedDataPath derived_data
[13:54:46]: ▸ Command line invocation:
[13:54:46]: ▸     /Applications/Xcode14.app/Contents/Developer/usr/bin/xcodebuild -resolvePackageDependencies -scheme Ably-iOS-Tests -project ./Ably.xcodeproj -derivedDataPath derived_data
[13:54:46]: ▸ User defaults from command line:
[13:54:46]: ▸     IDEDerivedDataPathOverride = /Users/aj/Development/ably-cocoa/derived_data
[13:54:46]: ▸     IDEPackageSupportUseBuiltinSCM = YES
[13:54:46]: ▸ --- xcodebuild: WARNING: Using the first of multiple matching destinations:
[13:54:46]: ▸ { platform:macOS, arch:arm64, variant:Mac Catalyst, id:00008103-000938D801D1001E }
[13:54:46]: ▸ { platform:macOS, arch:x86_64, variant:Mac Catalyst, id:00008103-000938D801D1001E }
[13:54:46]: ▸ { platform:macOS, arch:arm64, variant:Designed for [iPad,iPhone], id:00008103-000938D801D1001E }
[13:54:46]: ▸ { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device }
[13:54:46]: ▸ { platform:iOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-iphonesimulator:placeholder, name:Any iOS Simulator Device }
[13:54:46]: ▸ { platform:macOS, variant:Mac Catalyst, name:Any Mac }
[13:54:46]: ▸ { platform:iOS Simulator, id:CC474B3B-6A56-47E8-866C-63F7935B9A20, OS:16.0, name:iPad (9th generation) }
[13:54:46]: ▸ { platform:iOS Simulator, id:4C1EBD89-4EDE-46FB-BD91-09FD696C1E1D, OS:16.0, name:iPad Air (5th generation) }
[13:54:46]: ▸ { platform:iOS Simulator, id:A658B07E-131C-4196-ADA5-807BF3BB02BB, OS:16.0, name:iPad Pro (9.7-inch) }
[13:54:46]: ▸ { platform:iOS Simulator, id:C901A1C8-F8F7-4597-A75A-7B7E42EAF040, OS:16.0, name:iPad Pro (11-inch) (3rd generation) }
[13:54:46]: ▸ { platform:iOS Simulator, id:0A5FFA89-6ADF-49CB-ABD9-8E239AFB646E, OS:16.0, name:iPad Pro (12.9-inch) (5th generation) }
[13:54:46]: ▸ { platform:iOS Simulator, id:345D063E-AD41-4EBF-BDE5-79D9A55FD93D, OS:16.0, name:iPad mini (6th generation) }
[13:54:46]: ▸ { platform:iOS Simulator, id:901E7C9B-0AFB-4C0D-BF71-C712A229ECE8, OS:16.0, name:iPhone 8 }
[13:54:46]: ▸ { platform:iOS Simulator, id:02827B12-CB08-4EA0-BFB8-8195A29B8741, OS:16.0, name:iPhone 8 Plus }
[13:54:46]: ▸ { platform:iOS Simulator, id:E9468950-EE78-43CD-AF85-22CBE71CD309, OS:16.0, name:iPhone 11 }
[13:54:46]: ▸ { platform:iOS Simulator, id:CA8A7919-E05E-4331-A761-12EB50A0568E, OS:16.0, name:iPhone 11 Pro }
[13:54:46]: ▸ { platform:iOS Simulator, id:95B57FA7-04B4-4632-B5AC-08499FA855E6, OS:16.0, name:iPhone 11 Pro Max }
[13:54:46]: ▸ { platform:iOS Simulator, id:2550751A-A257-4F8F-85B1-55AF1D835164, OS:16.0, name:iPhone 12 }
[13:54:46]: ▸ { platform:iOS Simulator, id:8D99BBD0-4950-48AA-B484-1A387D313B56, OS:16.0, name:iPhone 12 Pro }
[13:54:46]: ▸ { platform:iOS Simulator, id:52BC78EF-4E3C-43EE-B99E-D7098697E718, OS:16.0, name:iPhone 12 Pro Max }
[13:54:46]: ▸ { platform:iOS Simulator, id:E20708E8-B388-4667-B3C3-203A3F298DF0, OS:16.0, name:iPhone 12 mini }
[13:54:46]: ▸ { platform:iOS Simulator, id:955DA9C8-0745-4EA9-AE43-BC6C612D94AA, OS:16.0, name:iPhone 13 }
[13:54:46]: ▸ { platform:iOS Simulator, id:44D4DA41-732B-4193-AFE2-6B8D6DFC0A04, OS:16.0, name:iPhone 13 Pro }
[13:54:46]: ▸ { platform:iOS Simulator, id:3085679C-2178-4BBC-A087-F1226ECCDF8E, OS:16.0, name:iPhone 13 Pro Max }
[13:54:46]: ▸ { platform:iOS Simulator, id:BAA2DDFF-A5CA-4662-9BFD-4C73A381080A, OS:16.0, name:iPhone 13 mini }
[13:54:46]: ▸ { platform:iOS Simulator, id:40E333E8-46D6-401D-BBD7-A4E84F01D35C, OS:16.0, name:iPhone 14 }
[13:54:46]: ▸ { platform:iOS Simulator, id:68C45E32-752B-4210-9B9F-52286E105C73, OS:16.0, name:iPhone 14 Plus }
[13:54:46]: ▸ { platform:iOS Simulator, id:56F4D83B-4538-4317-84FE-52A5556C868D, OS:16.0, name:iPhone 14 Pro }
[13:54:46]: ▸ { platform:iOS Simulator, id:A941A2E1-D078-4EA6-B139-C984B11860A8, OS:16.0, name:iPhone 14 Pro Max }
[13:54:46]: ▸ { platform:iOS Simulator, id:EAB8C0BA-18A6-4F06-846C-5D0FCB53BCF5, OS:16.0, name:iPhone SE (3rd generation) }
[13:54:46]: ▸ resolved source packages: 
[13:54:46]: $ xcodebuild -showBuildSettings -scheme Ably-iOS-Tests -project ./Ably.xcodeproj -derivedDataPath derived_data
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:arm64, variant:Mac Catalyst, id:00008103-000938D801D1001E }
{ platform:macOS, arch:x86_64, variant:Mac Catalyst, id:00008103-000938D801D1001E }
{ platform:macOS, arch:arm64, variant:Designed for [iPad,iPhone], id:00008103-000938D801D1001E }
{ platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device }
{ platform:iOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-iphonesimulator:placeholder, name:Any iOS Simulator Device }
{ platform:macOS, variant:Mac Catalyst, name:Any Mac }
{ platform:iOS Simulator, id:CC474B3B-6A56-47E8-866C-63F7935B9A20, OS:16.0, name:iPad (9th generation) }
{ platform:iOS Simulator, id:4C1EBD89-4EDE-46FB-BD91-09FD696C1E1D, OS:16.0, name:iPad Air (5th generation) }
{ platform:iOS Simulator, id:A658B07E-131C-4196-ADA5-807BF3BB02BB, OS:16.0, name:iPad Pro (9.7-inch) }
{ platform:iOS Simulator, id:C901A1C8-F8F7-4597-A75A-7B7E42EAF040, OS:16.0, name:iPad Pro (11-inch) (3rd generation) }
{ platform:iOS Simulator, id:0A5FFA89-6ADF-49CB-ABD9-8E239AFB646E, OS:16.0, name:iPad Pro (12.9-inch) (5th generation) }
{ platform:iOS Simulator, id:345D063E-AD41-4EBF-BDE5-79D9A55FD93D, OS:16.0, name:iPad mini (6th generation) }
{ platform:iOS Simulator, id:901E7C9B-0AFB-4C0D-BF71-C712A229ECE8, OS:16.0, name:iPhone 8 }
{ platform:iOS Simulator, id:02827B12-CB08-4EA0-BFB8-8195A29B8741, OS:16.0, name:iPhone 8 Plus }
{ platform:iOS Simulator, id:E9468950-EE78-43CD-AF85-22CBE71CD309, OS:16.0, name:iPhone 11 }
{ platform:iOS Simulator, id:CA8A7919-E05E-4331-A761-12EB50A0568E, OS:16.0, name:iPhone 11 Pro }
{ platform:iOS Simulator, id:95B57FA7-04B4-4632-B5AC-08499FA855E6, OS:16.0, name:iPhone 11 Pro Max }
{ platform:iOS Simulator, id:2550751A-A257-4F8F-85B1-55AF1D835164, OS:16.0, name:iPhone 12 }
{ platform:iOS Simulator, id:8D99BBD0-4950-48AA-B484-1A387D313B56, OS:16.0, name:iPhone 12 Pro }
{ platform:iOS Simulator, id:52BC78EF-4E3C-43EE-B99E-D7098697E718, OS:16.0, name:iPhone 12 Pro Max }
{ platform:iOS Simulator, id:E20708E8-B388-4667-B3C3-203A3F298DF0, OS:16.0, name:iPhone 12 mini }
{ platform:iOS Simulator, id:955DA9C8-0745-4EA9-AE43-BC6C612D94AA, OS:16.0, name:iPhone 13 }
{ platform:iOS Simulator, id:44D4DA41-732B-4193-AFE2-6B8D6DFC0A04, OS:16.0, name:iPhone 13 Pro }
{ platform:iOS Simulator, id:3085679C-2178-4BBC-A087-F1226ECCDF8E, OS:16.0, name:iPhone 13 Pro Max }
{ platform:iOS Simulator, id:BAA2DDFF-A5CA-4662-9BFD-4C73A381080A, OS:16.0, name:iPhone 13 mini }
{ platform:iOS Simulator, id:40E333E8-46D6-401D-BBD7-A4E84F01D35C, OS:16.0, name:iPhone 14 }
{ platform:iOS Simulator, id:68C45E32-752B-4210-9B9F-52286E105C73, OS:16.0, name:iPhone 14 Plus }
{ platform:iOS Simulator, id:56F4D83B-4538-4317-84FE-52A5556C868D, OS:16.0, name:iPhone 14 Pro }
{ platform:iOS Simulator, id:A941A2E1-D078-4EA6-B139-C984B11860A8, OS:16.0, name:iPhone 14 Pro Max }
{ platform:iOS Simulator, id:EAB8C0BA-18A6-4F06-846C-5D0FCB53BCF5, OS:16.0, name:iPhone SE (3rd generation) }

+--------------------------------------+--------------------------------------+
|                          Summary for scan 2.204.3                           |
+--------------------------------------+--------------------------------------+
| scheme                               | Ably-iOS-Tests                       |
| derived_data_path                    | derived_data                         |
| devices                              | ["iPhone 12"]                        |
| test_without_building                | false                                |
| xcargs                               | ABLY_ENV=sandbox                     |
|                                      | CLANG_ANALYZER_OUTPUT=plist-html     |
| output_directory                     | fastlane/test_output/sdk/test_iOS14  |
|                                      | _4                                   |
| project                              | ./Ably.xcodeproj                     |
| skip_detect_devices                  | false                                |
| ensure_devices_found                 | true                                 |
| force_quit_simulator                 | false                                |
| reset_simulator                      | false                                |
| disable_slide_to_type                | true                                 |
| reinstall_app                        | false                                |
| clean                                | true                                 |
| open_report                          | false                                |
| output_types                         | junit                                |
| buildlog_path                        | ~/Library/Logs/scan                  |
| include_simulator_logs               | false                                |
| xcodebuild_formatter                 | xcbeautify                           |
| output_remove_retry_attempts         | false                                |
| should_zip_build_products            | false                                |
| output_xctestrun                     | false                                |
| result_bundle                        | true                                 |
| use_clang_report_name                | false                                |
| disable_concurrent_testing           | false                                |
| skip_build                           | false                                |
| slack_use_webhook_configured_userna  | false                                |
| me_and_icon                          |                                      |
| slack_username                       | fastlane                             |
| slack_icon_url                       | https://fastlane.tools/assets/img/f  |
|                                      | astlane_icon.png                     |
| skip_slack                           | true                                 |
| slack_only_on_failure                | false                                |
| xcodebuild_command                   | env NSUnbufferedIO=YES xcodebuild    |
| skip_package_dependencies_resolutio  | false                                |
| n                                    |                                      |
| disable_package_automatic_updates    | false                                |
| use_system_scm                       | false                                |
| number_of_retries                    | 0                                    |
| fail_build                           | true                                 |
| xcode_path                           | /Applications/Xcode14.app            |
+--------------------------------------+--------------------------------------+

[13:54:47]: Disabling 'Slide to Type' iPhone 12
[13:54:47]: $ /usr/libexec/PlistBuddy -c "Add :KeyboardContinuousPathEnabled bool false" /Users/aj/Library/Developer/CoreSimulator/Devices/2550751A-A257-4F8F-85B1-55AF1D835164/data/Library/Preferences/com.apple.keyboard.ContinuousPath.plist >/dev/null 2>&1
[13:54:47]: $ set -o pipefail && env NSUnbufferedIO=YES xcodebuild -scheme Ably-iOS-Tests -project ./Ably.xcodeproj -derivedDataPath derived_data -destination 'platform=iOS Simulator,id=2550751A-A257-4F8F-85B1-55AF1D835164' -resultBundlePath 'fastlane/test_output/sdk/test_iOS14_4/Ably-iOS-Tests.xcresult' ABLY_ENV=sandbox CLANG_ANALYZER_OUTPUT=plist-html clean build test | tee '/Users/aj/Library/Logs/scan/Ably-iOS-Tests-Ably-iOS-Tests.log' | xcbeautify
[13:54:47]: ▸ Loading...
[13:54:47]: ▸ sh: xcbeautify: command not found
[13:54:53]: ▸ ** BUILD FAILED **
[13:54:53]: ▸ The following build commands failed:
[13:54:53]: ▸ 	Ld /Users/aj/Development/ably-cocoa/derived_data/Build/Products/Debug-iphonesimulator/Ably.framework/Ably normal (in target 'Ably-iOS' from project 'Ably')
[13:54:53]: ▸ (1 failure)
[13:54:56]: ▸ Testing failed:
[13:54:56]: ▸ 	Undefined symbol: _OBJC_CLASS_$_ARTDeltaCodec
[13:54:56]: ▸ 	Testing cancelled because the build failed.
[13:54:56]: ▸ ** TEST FAILED **
[13:54:56]: ▸ The following build commands failed:
[13:54:56]: ▸ 	Ld /Users/aj/Development/ably-cocoa/derived_data/Build/Products/Debug-iphonesimulator/Ably.framework/Ably normal (in target 'Ably-iOS' from project 'Ably')
[13:54:56]: ▸ (1 failure)
sh: xcbeautify: command not found
** BUILD FAILED **


The following build commands failed:
	Ld /Users/aj/Development/ably-cocoa/derived_data/Build/Products/Debug-iphonesimulator/Ably.framework/Ably normal (in target 'Ably-iOS' from project 'Ably')
(1 failure)
Testing failed:
	Undefined symbol: _OBJC_CLASS_$_ARTDeltaCodec
	Testing cancelled because the build failed.

** TEST FAILED **


The following build commands failed:
	Ld /Users/aj/Development/ably-cocoa/derived_data/Build/Products/Debug-iphonesimulator/Ably.framework/Ably normal (in target 'Ably-iOS' from project 'Ably')
(1 failure)
[13:54:57]: Exit status: 127
+------------------------------+--------------------------------------+
|                            Lane Context                             |
+------------------------------+--------------------------------------+
| DEFAULT_PLATFORM             | ios                                  |
| PLATFORM_NAME                | ios                                  |
| LANE_NAME                    | ios test_iOS14_4                     |
| SCAN_GENERATED_XCRESULT_PATH | /Users/aj/Development/ably-cocoa/fa  |
|                              | stlane/test_output/sdk/test_iOS14_4  |
|                              | /Ably-iOS-Tests.xcresult             |
| SCAN_DERIVED_DATA_PATH       | derived_data                         |
| SCAN_GENERATED_PLIST_FILES   | []                                   |
| SCAN_GENERATED_PLIST_FILE    |                                      |
+------------------------------+--------------------------------------+
[13:54:57]: Error building the application. See the log above.

+------+------------------+-------------+
|           fastlane summary            |
+------+------------------+-------------+
| Step | Action           | Time (in s) |
+------+------------------+-------------+
| 1    | default_platform | 0           |
| 💥   | run_tests        | 11          |
+------+------------------+-------------+

[13:54:57]: fastlane finished with errors

[!] Error building the application. See the log above.

#######################################################################
# fastlane 2.210.1 is available. You are on 2.204.3.
# You should use the latest version.
# Please update using `bundle update fastlane`.
#######################################################################

2.210.1 Hotfix for deliver and pilot
* [pilot][deliver] Fix how to encode base64 p8 key on deliver and pilot (#20669) via freddi(Yuki Aki) (@freddi-kit)

2.210.0 Improvements
* [deliver][pilot] use altool instead of using iTMSTransporter for Xcode 14 (#20631) via freddi(Yuki Aki) (@freddi-kit)
* [docs][run_tests] fix typo and improve phrasing of documentation (#20585) via Roger Oba (@rogerluan)

2.209.1 Improvements
* [fastlane_core] install all Apple WWDR Intermediate Certificates (#20537) via Tony Li (@crazytonyli)
* [Fastlane.swift] the word phrasing used has been standardized. (#20543) via Yusuke Arakawa (@nekolaboratory)
* [spaceship] ignoring case sensitive when requesting SMS (#20436) via harrimaatta (@harrimaatta)

To see all new releases, open https://github.com/fastlane/fastlane/releases

Please update using `bundle update fastlane`
make: *** [test_iOS] Error 1

┆Issue is synchronized with this Jira Uncategorised by Unito

lawrence-forooghian added a commit that referenced this issue Oct 19, 2022
…pdate`

This stops the usage of
Scripts/carthage-with-workaround-for-issue-3019.sh when building the
project’s dependencies using Carthage for local development (i.e. when
running `make update` or one of its sub-commands).

This file was seems to have been originally introduced to fix an error
related to duplicate architectures when running Carthage. I don’t get
any errors switching back to plain Carthage without a wrapper when
running `make update` on my M1 Pro machine, using Carthage 0.38.0. Given
that the linked issue Carthage/Carthage#3019
is now marked as resolved, I guess something was changed in Carthage
that resolves this for us 🤷.

This closes #1506, where we were seeing "Undefined symbol:
_OBJC_CLASS_$_ARTDeltaCodec" errors running `make test_iOS` on M1*
machines. I guess in the part of the script where we exclude ARM
architectures (I don’t exactly know what that means) we had stopped
building something that we needed to run on the current platform.

We’re still using this file for the `make carthage_package` task. We
should check whether we need it there too, but since that might have
user-facing consequences (instead of just breaking our development
environment) I don’t want to do that hastily. I’ve created a separate
issue #1509 for that.
lawrence-forooghian added a commit that referenced this issue Oct 20, 2022
…pdate`

This stops the usage of
Scripts/carthage-with-workaround-for-issue-3019.sh when building the
project’s dependencies using Carthage for local development (i.e. when
running `make update` or one of its sub-commands).

This file was seems to have been originally introduced to fix an error
related to duplicate architectures when running Carthage. I don’t get
any errors switching back to plain Carthage without a wrapper when
running `make update` on my M1 Pro machine, using Carthage 0.38.0. Given
that the linked issue Carthage/Carthage#3019
is now marked as resolved, I guess something was changed in Carthage
that resolves this for us 🤷.

This closes #1506, where we were seeing "Undefined symbol:
_OBJC_CLASS_$_ARTDeltaCodec" errors running `make test_iOS` on M1*
machines. I guess in the part of the script where we exclude ARM
architectures (I don’t exactly know what that means) we had stopped
building something that we needed to run on the current platform.

We’re still using this file for the `make carthage_package` task. We
should check whether we need it there too, but since that might have
user-facing consequences (instead of just breaking our development
environment) I don’t want to do that hastily. I’ve created a separate
issue #1509 for that.
lawrence-forooghian added a commit that referenced this issue Oct 24, 2022
…pdate`

This stops the usage of
Scripts/carthage-with-workaround-for-issue-3019.sh when building the
project’s dependencies using Carthage for local development (i.e. when
running `make update` or one of its sub-commands).

This file was seems to have been originally introduced to fix an error
related to duplicate architectures when running Carthage. I don’t get
any errors switching back to plain Carthage without a wrapper when
running `make update` on my M1 Pro machine, using Carthage 0.38.0. Given
that the linked issue Carthage/Carthage#3019
is now marked as resolved, I guess something was changed in Carthage
that resolves this for us 🤷.

This closes #1506, where we were seeing "Undefined symbol:
_OBJC_CLASS_$_ARTDeltaCodec" errors running `make test_iOS` on M1*
machines. I guess in the part of the script where we exclude ARM
architectures (I don’t exactly know what that means) we had stopped
building something that we needed to run on the current platform.

We’re still using this file for the `make carthage_package` task. We
should check whether we need it there too, but since that might have
user-facing consequences (instead of just breaking our development
environment) I don’t want to do that hastily. I’ve created a separate
issue #1509 for that.
lawrence-forooghian added a commit that referenced this issue Oct 31, 2023
…pdate`

This stops the usage of
Scripts/carthage-with-workaround-for-issue-3019.sh when building the
project’s dependencies using Carthage for local development (i.e. when
running `make update` or one of its sub-commands).

This file was seems to have been originally introduced to fix an error
related to duplicate architectures when running Carthage. I don’t get
any errors switching back to plain Carthage without a wrapper when
running `make update` on my M1 Pro machine, using Carthage 0.38.0. Given
that the linked issue Carthage/Carthage#3019
is now marked as resolved, I guess something was changed in Carthage
that resolves this for us 🤷.

This closes #1506, where we were seeing "Undefined symbol:
_OBJC_CLASS_$_ARTDeltaCodec" errors running `make test_iOS` on M1*
machines. I guess in the part of the script where we exclude ARM
architectures (I don’t exactly know what that means) we had stopped
building something that we needed to run on the current platform.

We’re still using this file for the `make carthage_package` task. We
should check whether we need it there too, but since that might have
user-facing consequences (instead of just breaking our development
environment) I don’t want to do that hastily. I’ve created a separate
issue #1509 for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant