Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback host is being discarded before fallbackRetryTimeout elapses #1683

Closed
lawrence-forooghian opened this issue Apr 18, 2023 · 0 comments · Fixed by #1684
Closed

Fallback host is being discarded before fallbackRetryTimeout elapses #1683

lawrence-forooghian opened this issue Apr 18, 2023 · 0 comments · Fixed by #1684
Assignees
@lawrence-forooghian
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 18, 2023 •
edited

Running RestClientTests on my development machine reveals multiple test failures which are caused by the fact that the SDK incorrectly believes that the timeout described by RSC15f has elapsed.

The underlying cause is that we're not initializing the value (size) pointed to by the oldlenp pointer passed to sysctl.

These tests are not failing in CI, which leads me to wonder if the symptoms only manifest on ARM devices (e.g. my development machine). We don't have an quick way of running our unit tests on actual iOS devices so I haven't been able to confirm if they're affected.
@lawrence-forooghian lawrence-forooghian added the bug Something isn't working. It's clear that this does need to be fixed. label Apr 18, 2023
@lawrence-forooghian lawrence-forooghian self-assigned this Apr 18, 2023
lawrence-forooghian added a commit that referenced this issue Apr 19, 2023
@lawrence-forooghian
Fix premature discarding of fallback host
aef5062 
Running RestClientTests on my development machine reveals multiple test
failures which are caused by the fact that the SDK incorrectly believes
that the timeout described by RSC15f has elapsed.

The underlying cause is that we're not initializing the value pointed to
by the `oldlenp` pointer passed to `sysctl`.

These tests are not failing in CI, which leads me to wonder if the
symptoms only manifest on ARM devices (e.g. my development machine). We
don't have an quick way of running our unit tests on actual iOS devices
so I haven't been able to confirm if they're affected.

Resolves #1683.
@lawrence-forooghian lawrence-forooghian mentioned this issue Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix premature discarding of fallback host ably/ably-cocoa
1 participant
@lawrence-forooghian