Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable skipped presence tests #1889

Closed
Tracked by #1848
maratal opened this issue Mar 13, 2024 · 2 comments · Fixed by #1907
Closed
Tracked by #1848

Re-enable skipped presence tests #1889

maratal opened this issue Mar 13, 2024 · 2 comments · Fixed by #1907
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@maratal
Copy link
Collaborator

maratal commented Mar 13, 2024 •
edited by sync-by-unito bot

I strongly feel we should unskip/fix most of / all of presence tests. Those are needed to make sure protocol 2.0 / no connection serial works as expected. We did the same for ably-java sometime back ably/ably-java#989

Originally posted by sacOO7 in #1886 (comment)

┆Issue is synchronized with this Jira Task by Unito
This was referenced Mar 13, 2024
Merged
Closed
@maratal
Copy link
Collaborator Author

maratal commented Mar 15, 2024

This should be solved with an issue for every test.

@maratal maratal mentioned this issue Mar 15, 2024
Closed
4 tasks
@maratal maratal mentioned this issue Apr 21, 2024
Merged
@lawrence-forooghian lawrence-forooghian added the failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. label Apr 22, 2024
@maratal maratal changed the title Re-enable skipped presence tests (umbrella issue) Re-enable skipped presence tests May 3, 2024
@maratal
Copy link
Collaborator Author

maratal commented May 3, 2024

Related issue #1914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ECO-4695] Unskip presense tests ably/ably-cocoa
2 participants
@maratal @lawrence-forooghian