Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix presence / ignored presence tests #989

Merged
merged 7 commits into from Mar 4, 2024
Merged

Fix presence / ignored presence tests #989

merged 7 commits into from Mar 4, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Mar 1, 2024 •
edited

@github-actions github-actions bot temporarily deployed to staging/pull/989/features March 1, 2024 12:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/989/javadoc March 1, 2024 12:11 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/989/features March 1, 2024 12:12 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/989/javadoc March 1, 2024 12:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/989/features March 1, 2024 13:05 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/989/javadoc March 1, 2024 13:06 Inactive
@sacOO7 sacOO7 changed the title Fix/presence tests Fix ignored presence tests Mar 1, 2024
@sacOO7 sacOO7 marked this pull request as ready for review March 1, 2024 13:36
@sacOO7 sacOO7 self-assigned this Mar 1, 2024
@sacOO7 sacOO7 requested review from ttypic and AndyTWF March 1, 2024 13:37
@github-actions github-actions bot temporarily deployed to staging/pull/989/features March 4, 2024 09:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/989/javadoc March 4, 2024 09:48 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/989/features March 4, 2024 10:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/989/javadoc March 4, 2024 10:14 Inactive
@sacOO7 sacOO7 changed the title Fix ignored presence tests Fix presence / ignored presence tests Mar 4, 2024
ttypic
ttypic approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Mar 4, 2024

Thanks !

@sacOO7 sacOO7 merged commit 4f71ed8 into main Mar 4, 2024
9 checks passed
@sacOO7 sacOO7 deleted the fix/presence-tests branch March 4, 2024 13:23
@sacOO7 sacOO7 mentioned this pull request Mar 12, 2024
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@AndyTWF AndyTWF Awaiting requested review from AndyTWF

Assignees

@sacOO7 sacOO7

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable and fix tests in RealtimePresenceTest Failing RealtimePresenceTest presence_get
2 participants
@sacOO7 @ttypic