Treat warnings as errors across the codebase #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
requested review from
QuintinWillison,
ben-xD,
lukasz-szyszkowski and
maratal
lukasz-szyszkowski
approved these changes
Dec 2, 2021
maratal
approved these changes
Dec 2, 2021
Our tests are using the deprecated -ARTClientOptions.fallbackHostsUseDefault property. We can’t remove this usage until we remove the property. But we want to be able to turn on “treat warnings as errors” so we need a way to suppress the resultant compiler warning. Swift doesn’t really provide options for suppressing warnings, so instead we take advantage of the fact that it doesn’t emit warnings when using deprecated functionality inside of a method which is itself marked as deprecated. See https://forums.swift.org/t/swift-should-allow-for-suppression-of-warnings-especially-those-that-come-from-objective-c/19216/68.
The warning is: > Treating a forced downcast to 'ARTMessage' as optional will never > produce 'nil'
lawrence-forooghian
force-pushed
the
treat-warnings-as-errors
branch
from
391dfe5
to
122ae44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
Hopefully it's fairly self-explanatory why this is a good thing — warnings aren't in any way flagged by CI otherwise, so it's far too easy to introduce new ones.