Improve test file structure and naming #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it’s a bit confusing to have them both mixed into a single list.
This makes them: - more descriptively named - easier to find through a fuzzy file matcher that only matches on the basename, like Xcode’s “Open Quickly”
lawrence-forooghian
requested review from
ben-xD,
lukasz-szyszkowski,
maratal and
QuintinWillison
lukasz-szyszkowski
approved these changes
Dec 2, 2021
ben-xD
approved these changes
Dec 2, 2021
lawrence-forooghian
deleted the
1203-improve-test-file-structure-and-naming
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully makes our test files easier to navigate, by separating test files from test utilities, and naming the test files to make it clear they’re tests. See commit messages for more details.
This is an updated version of the closed PR #1191.
Closes #1203.