Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed channel name url encoding #1451

Merged
merged 2 commits into from Jul 27, 2022
Merged

Fixed channel name url encoding #1451

merged 2 commits into from Jul 27, 2022

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Jul 24, 2022

Closes #1449

@maratal
Using NSCharacterSet.URLHostAllowedCharacterSet, because it doesn't…
b5c5e83 
… include '/', which can be used in channel names across other platforms.

Whereas `URLPathAllowedCharacterSet` includes '/' as a valid path character, so when a channel name contains it, it is not encoded and the `REST` path becomes broken.
@maratal
Test for slash in channel name
e11730f
@maratal maratal requested a review from ikbalkaya July 24, 2022 15:29
ikbalkaya
ikbalkaya approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,, thanks

@maratal maratal merged commit 8f59040 into main Jul 27, 2022
@maratal maratal deleted the fix/1449-channel-name-url-encoding branch July 27, 2022 08:02
@maratal maratal changed the title Fix/1449 channel name url encoding Fixed channel name url encoding Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikbalkaya ikbalkaya ikbalkaya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Channel names are not properly url-encoded
2 participants
@maratal @ikbalkaya