RSA8f3 #350
RSA8f3 #350
Conversation
| let token = getTestToken() | ||
| let options = ARTClientOptions(token: token) | ||
| options.environment = "sandbox" | ||
| options.clientId = "john" |
There was a problem hiding this comment.
See PR for RSA8f4, this is wrong, you need a token with a wildcard clientId and clientId is not set in the options.
There was a problem hiding this comment.
Done 5092393.
ricardopereira
force-pushed
the
rsa8f3
branch
2 times, most recently
from
5092393
to
aefe195
Compare
| } | ||
| } | ||
| } | ||
| expect(rest.auth.clientId).to(beNil()) |
There was a problem hiding this comment.
RSA8f3 says: "Check that Auth#clientId is a string with value '*'"
There was a problem hiding this comment.
@tcard Then this is wrong https://github.com/ably/ably-ios/blob/master/Source/ARTAuth.m#L346? I saw RSA12 and it should be nil. The nil value indicates that the client has not yet been able to confirm its identity. I think RSA8f3 spec is wrong. WDYT?
There was a problem hiding this comment.
The code is wrong, yes. I don't really think there's a conflict between RSA8f3 and RSA12. RSA12a has as precondition "The clientId attribute of a TokenRequest or TokenDetails used for authentication is null, or ConnectionDetails#clientId is null following a connection to Ably", which doesn't apply here.
There was a problem hiding this comment.
Done cf241cd. (not passing)
|
@ricardopereira this was merged without cf241cd? I think that was a mistake |
|
You're right. Thanks. |
No description provided.