-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add laravel echo agent headers #170
Conversation
sacOO7
commented
Oct 26, 2022
- Added agent headers for laravel-echo and laravel-broadcaster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused as to how we're using emitters
. In the schema we describe it as:
An array containing the names of Ably SDKs which directly emit this identifier. SDK names must match the repository name we use in GitHub (i.e. the component that appears after ably org in the URL).
Looking at ably/laravel-broadcaster#7, which I clearly aligns with this PR (i.e. implements these product identifier emitters), my expectation is that we should be seeing:
"emitters": ["laravel-broadcaster"]
Where "type"
of "wrapper"
is clearly still appropriate.
@QuintinWillison My interpretation of "Ably SDKs which directly emit this identifier" from that schema is SDKs which actually implement the sending of the Ably-Agent header (or param), so if laravel-broadcaster emits the agent by using the ably-php client option then it's indirectly emitting the identifier. I think we already interpret this inconsistently in It would be good to know more about what this field is actually used for in the backend and then make the schema more specific, @lmars WDYT? |
The |
Maybe rename it to |
In 5f47be5 I've updated this pull request to conform with the change made in #172 (removed the I remain of the opinion that I expressed previously, so will not be approving this pull request in current state. However, it can freely merge to |
We've lessened the impact of the change I was objecting to.