Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On unhandled exception should not put channel into failed state #378

Closed
marto83 opened this issue Oct 7, 2019 · 3 comments
Closed

On unhandled exception should not put channel into failed state #378

marto83 opened this issue Oct 7, 2019 · 3 comments
Assignees
@marto83
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@marto83
Copy link
Contributor

marto83 commented Oct 7, 2019

If there is an unhandled exception it should log an error message and leave the channel in its current state
@marto83 marto83 self-assigned this Oct 7, 2019
@marto83 marto83 added the bug Something isn't working. It's clear that this does need to be fixed. label Oct 7, 2019
@mattheworiordan
Copy link
Member

@marto83 this is described in https://docs.ably.io/client-lib-development-guide/features/#RSC20 btw. Do you know if the SDK claims to support RSC20?

marto83 added a commit that referenced this issue Oct 7, 2019
@marto83
Handle case with presence with no messages
e3d2790 
Issues: #379 and #378

Now we make sure therewe handle the case with no presence is a channel and
at the same time it no longer throws an exception but logs it
appropirately

This fix does not cover any of the Exception handling spec items under
RSC20
@marto83
Copy link
Contributor Author

marto83 commented Oct 22, 2019

This has been implemented for the presence case but I'll leave it open to make sure I add a test for RSC20.

@marto83
Copy link
Contributor Author

marto83 commented Dec 20, 2019 •
edited

Created a separate issue to implement RSC20 - #389

@marto83 marto83 closed this as completed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marto83 marto83

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @marto83