Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MessageExtras #433

Merged
merged 4 commits into from
Sep 7, 2020
Merged

Refactor MessageExtras #433

merged 4 commits into from
Sep 7, 2020

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Aug 21, 2020 •
edited

@sacOO7
Marked delta property to be private, Modified constructor accessor
30bcd91 
Moved deserialization to internal static method
@sacOO7 sacOO7 requested a review from marto83 August 25, 2020 19:03
marto83
marto83 approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@marto83 marto83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sacOO7 sacOO7 changed the title [WIP] Refactor MessageExtras Refactor MessageExtras Aug 26, 2020
@QuintinWillison QuintinWillison removed the request for review from mattheworiordan September 7, 2020 07:09
@QuintinWillison QuintinWillison merged commit 16df9a1 into main Sep 7, 2020
@QuintinWillison QuintinWillison deleted the feature/422-refactor-message-extras branch September 7, 2020 07:09
@marto83 marto83 mentioned this pull request Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marto83 marto83 marto83 approved these changes

@QuintinWillison QuintinWillison Awaiting requested review from QuintinWillison

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MessageExtras to comply with TM2i
3 participants
@sacOO7 @marto83 @QuintinWillison