Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor example app to be more readable #212

Closed
ben-xD opened this issue Nov 10, 2021 · 1 comment
Closed

Refactor example app to be more readable #212

ben-xD opened this issue Nov 10, 2021 · 1 comment
Assignees
@ben-xD
Labels
enhancement New feature or improved functionality.

Comments

@ben-xD
Copy link
Contributor

ben-xD commented Nov 10, 2021 •
edited by ably-sync-bot

Majority of the example app lives in https://github.com/ably/ably-flutter/blob/main/example/lib/main.dart, which is a stateful widget of 815 lines. We should refactor the code into multiple widgets, service classes and constants, and also using state management solutions if necessary.

┆Issue is synchronized with this Jira Story by Unito
@ben-xD ben-xD added the enhancement New feature or improved functionality. label Nov 10, 2021
@ben-xD ben-xD self-assigned this Nov 10, 2021
@ben-xD ben-xD mentioned this issue Nov 11, 2021
Open
@ben-xD
Copy link
Contributor Author

ben-xD commented Nov 30, 2021

We could of course do more work in refactoring, but a big step was done by #240

@ben-xD ben-xD closed this as completed Nov 30, 2021
@owenpearson owenpearson mentioned this issue Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-xD ben-xD

Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ben-xD