Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flutter and/or Dart runtime version to Ably-Agent header, if possible #286

Closed
QuintinWillison opened this issue Jan 5, 2022 · 0 comments · Fixed by #367
Closed

Add Flutter and/or Dart runtime version to Ably-Agent header, if possible #286

QuintinWillison opened this issue Jan 5, 2022 · 0 comments · Fixed by #367
Labels
enhancement New feature or improved functionality.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Jan 5, 2022

The work done under #188 only added the {{ably-flutter}} product.

It looks like {{dart:io}}'s {{Platform}} class has a [static version property|https://api.flutter.dev/flutter/dart-io/Platform/version.html].

In terms of Flutter version, [this approach|https://stackoverflow.com/a/60581960/392847] seems very hacky and would require the app builder to do something more than simply include our SDK. As such, it feels like a non-starter for our context.

@QuintinWillison QuintinWillison added the enhancement New feature or improved functionality. label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

Successfully merging a pull request may close this issue.

1 participant