Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChannelStateChange property resumed should not be nullable #297

Closed
QuintinWillison opened this issue Jan 19, 2022 · 0 comments · Fixed by #313
Closed

ChannelStateChange property resumed should not be nullable #297

QuintinWillison opened this issue Jan 19, 2022 · 0 comments · Fixed by #313
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Jan 19, 2022 •
edited by sync-by-unito bot

See {{lib/src/realtime/src/channel_state_event.dart}}

This was apparently fixed in #270, but I've had to close that PR as the work done there has too many conflicts with {{main}} due to my decision not to merge intermediate work.

This issue is being created for the work to be done under to replicate what had been done in that PR, as well as to validate that the work that was proposed there was valid and correct.
@QuintinWillison QuintinWillison added the bug Something isn't working. It's clear that this does need to be fixed. label Jan 19, 2022
@ikurek ikurek mentioned this issue Feb 4, 2022
Merged
@QuintinWillison QuintinWillison linked a pull request Feb 7, 2022 that will close this issue
Channel resumed parameter now has to be non-null #313
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Channel resumed parameter now has to be non-null ably/ably-flutter
1 participant
@QuintinWillison