Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resultForDeactivate and resultForActivate are set to null in some situations in Android plugin #304

Closed
ikbalkaya opened this issue Jan 24, 2022 · 1 comment · Fixed by #307
Assignees

Comments

@ikbalkaya
Copy link
Contributor

ikbalkaya commented Jan 24, 2022

Problem
{{resultForDeactivate}} and {{resultForActivate}} are set to null (sometimes, in some devices) that resulted customer reported crashes happening. See
#298

Suspected cause
{{PushActivationEventHandlers}} class has a declared inner broadcast receivers that access to {{resultForActivate}} and {{resultForDeactivate}} on {{onRecieve}} method. However it's possible (?) that PushActivationEventHandlers is disposed while broadcast receiver still receives messages (most probably on background).

@ikbalkaya ikbalkaya self-assigned this Jan 24, 2022
@ikbalkaya
Copy link
Contributor Author

I did some tests to confirm whether broadcast receiver can exist in absense of PushActivationEventHandlers. Looks like it's the case. Setting up the PushActivationEventHandlers instance or any of its instance variables to null won't affect the ability for broadcast receiver to receive messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants