Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing link to ApplicationState in documentation #335

Closed
ikurek opened this issue Feb 21, 2022 · 0 comments · Fixed by #336
Closed

Missing link to ApplicationState in documentation #335

ikurek opened this issue Feb 21, 2022 · 0 comments · Fixed by #336
Assignees
@ikurek
Labels
documentation Improvements or additions to public interface documentation (API reference or readme).

Comments

@ikurek
Copy link
Contributor

ikurek commented Feb 21, 2022 •
edited by sync-by-unito bot

Dartdoc output indicates that a link to {{[ApplicationState]}} in {{PushNotificationEvents}} class doesn't lead anywhere. Most probably the {{ApplicationState}} class was removed and the comment link is a leftover and should be removed. Dartdoc output:

{code}
warning: unresolved doc reference [ApplicationState]
from ably_flutter.PushNotificationEvents.onNotificationTap: (file:///home/runner/work/ably-flutter/ably-flutter/lib/src
{code}
It would be nice to remove that link, to avoid end-user confusion with this method
@ikurek ikurek added the documentation Improvements or additions to public interface documentation (API reference or readme). label Feb 21, 2022
@ikurek ikurek self-assigned this Feb 21, 2022
This was referenced Feb 21, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikurek ikurek

Labels
documentation Improvements or additions to public interface documentation (API reference or readme).
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated ApplicationState docs reference ably/ably-flutter
1 participant
@ikurek