Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Android 21+ #74

Closed
SogoGolf opened this issue Dec 23, 2020 · 8 comments · Fixed by #75
Closed

support for Android 21+ #74

SogoGolf opened this issue Dec 23, 2020 · 8 comments · Fixed by #75

Comments

@SogoGolf
Copy link

SogoGolf commented Dec 23, 2020

hi folks, can you please provide support for Android 21+ ? At moment its Android 24+, but our app(s) need to support a minimum of 21.

┆Issue is synchronized with this Jira Uncategorised by Unito

@markcoxsmith
Copy link

Hi @SogoGolf , Thanks a lot for the request and can I confirm that you are referring to Android API 21? Will pass this onto our product team

@tiholic tiholic linked a pull request Jan 4, 2021 that will close this issue
@SogoGolf
Copy link
Author

SogoGolf commented Jan 4, 2021

Yes that's correct, many thanks

@tiholic
Copy link
Contributor

tiholic commented Jan 8, 2021

@SogoGolf can you please point your dependency to main branch and confirm support for Android 21?

@tiholic tiholic reopened this Jan 8, 2021
@SogoGolf
Copy link
Author

SogoGolf commented Feb 7, 2021

sorry for the delay. at moment we've got this in pubspec.yaml for Ably:

ably_flutter_plugin: ^1.0.0+dev.2

did you need us to test this against a different version ?

@tiholic
Copy link
Contributor

tiholic commented Feb 12, 2021

@SogoGolf yes,

You can try using below configuration in your pubspec.yaml

dependencies:
  ably_flutter_plugin:
    git: https://github.com/ably/ably-flutter

Ref: https://dart.dev/tools/pub/dependencies#git-packages

@SogoGolf
Copy link
Author

I gave that a try ;

  • changed pubspec.yaml per above
  • set min SDK to 21 in app/build.gradle
  • flutter clean
  • flutter pub get

No issues thus far.

Launched the app in debug mode and saw this error:

1: Task failed with an exception.
-----------
* Where:
Build file '/.pub-cache/git/ably-flutter-7aa0f091bbc45222eca7aa2273036288faec2371/android/build.gradle' line: 26

* What went wrong:
A problem occurred evaluating project ':ably_flutter_plugin'.
> Could not find method coreLibraryDesugaring() for arguments [com.android.tools:desugar_jdk_libs:1.1.1] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

@tiholic
Copy link
Contributor

tiholic commented Feb 19, 2021

@SogoGolf these instructions should help: https://github.com/ably/ably-flutter#android

You may also refer to respective files in example/android folder.

@QuintinWillison
Copy link
Contributor

Closing this issue for lack of activity, suggesting that it was solved by depending on a more recent version of this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants