Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel Attach #299

Merged
merged 42 commits into from May 27, 2021
Merged

Channel Attach #299

merged 42 commits into from May 27, 2021

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Mar 21, 2021

@sacOO7 sacOO7 requested a review from tcard March 21, 2021 14:17
tcard
tcard reviewed Mar 23, 2021
View reviewed changes
ably/export_test.go Outdated Show resolved Hide resolved
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Apr 8, 2021

Channel options are not implemented yet, we need to implement them as a part of RTL4k, RTL4l and RTL4m

@tcard tcard mentioned this pull request Apr 12, 2021
Merged
@sacOO7
Added custom timer for attach timeout, updated transitioner
232d447
@sacOO7
Updated tests with transitioner
250c40e
@sacOO7
Added channel attaching error capture for channel in attaching state,
e4f7e43 
updated todo's for tests need to be executed using transitioner
@sacOO7
Added realtime transitioner based implementation to remaining mocked …
2ccf76d 
…tests
@sacOO7
Added test for RTL4g, if channel in failed state, proceed with attach
3f0616c
@sacOO7
Fixed tests, added missing timer consumers for channel attach
9660b3a
@sacOO7
Added channel mode and params to channeloptions
e164a76
@sacOO7
Added unit tests for channel options channelModes
616d788
@sacOO7
Moved channel mode and channel param under crypto
1dc66cc
@sacOO7
Added params to protocolMessage, added extension to convert channelModes
ed086ff 
to ProtocolMessage flags
@sacOO7
Added channelOptions to realtimeChannel, added message serialization and
f86c16c 
deserialization for the same
@sacOO7
Added messagerecorder extension to check if message was sent with count,
f8484ba 
updated tests with messagerecorder
@sacOO7
Updated setters and readonly getter for channel modes and params
f973167
@sacOO7
Added latest message finder recorder, updated channel spec for channel
62a1c83 
modes and flags
@sacOO7
Added test for insufficient attach permission
357e89e
@sacOO7
Added flag set method to setup flags, updated tests for the same
ba6ce15
@sacOO7
Added internal attachresume flag to the realtimechannel, added cases
b5a9c24 
to set the flag
@sacOO7 sacOO7 marked this pull request as ready for review April 22, 2021 15:15
tcard
tcard reviewed May 18, 2021
View reviewed changes
ably/ablytest/recorders.go Outdated Show resolved Hide resolved
ably/proto/crypto_test.go Outdated Show resolved Hide resolved
ably/realtime_channel.go Outdated Show resolved Hide resolved
ably/realtime_channel.go Outdated Show resolved Hide resolved
ably/realtime_channel.go Outdated Show resolved Hide resolved
ably/realtime_channel.go Show resolved Hide resolved
ably/realtime_channel.go Outdated Show resolved Hide resolved
ably/realtime_channel.go Show resolved Hide resolved
ably/realtime_channel.go Show resolved Hide resolved
tcard
tcard reviewed May 18, 2021
View reviewed changes
ably/realtime_channel_spec_test.go Outdated Show resolved Hide resolved
ably/realtime_channel_spec_test.go Show resolved Hide resolved
ably/realtime_channel_spec_test.go Outdated Show resolved Hide resolved
ably/realtime_channel_spec_test.go Show resolved Hide resolved
ably/realtime_channel_spec_test.go Outdated Show resolved Hide resolved
ably/realtime_channel.go Outdated Show resolved Hide resolved
ably/realtime_channel_spec_test.go Show resolved Hide resolved
ably/realtime_channel.go Outdated Show resolved Hide resolved
ably/realtime_channel.go Outdated Show resolved Hide resolved
@sacOO7
Changed Modes and Params to return readonly data
3251650
@sacOO7
Updated tests, added connection waiter for naked connects without wai…
d461373 
…ters
@sacOO7
Merge branch 'integration/1.2' into fix/211-RTL4-channel-attach
514e2b8 
# Conflicts:
#	ably/ablytest/recorders.go
#	ably/proto/protocol_message.go
#	ably/realtime_channel.go
#	ably/realtime_channel_spec_test.go
#	ably/transitioner_test.go
tcard
tcard suggested changes May 20, 2021
View reviewed changes
Copy link
Contributor

@tcard tcard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change review status so that it doesn't appear as "approved".

@sacOO7 sacOO7 requested a review from tcard May 23, 2021 22:47
tcard
tcard reviewed May 25, 2021
View reviewed changes
ably/realtime_channel.go Outdated Show resolved Hide resolved
ably/realtime_channel.go Outdated Show resolved Hide resolved
@sacOO7 sacOO7 requested a review from tcard May 26, 2021 22:46
tcard
tcard reviewed May 27, 2021
View reviewed changes
ably/realtime_channel.go Outdated Show resolved Hide resolved
@sacOO7 sacOO7 requested a review from tcard May 27, 2021 13:32
@sacOO7 sacOO7 merged commit 6c55460 into integration/1.2 May 27, 2021
@sacOO7 sacOO7 deleted the fix/211-RTL4-channel-attach branch May 27, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmars lmars lmars approved these changes

@tcard tcard tcard approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sacOO7 @lmars @tcard