Rename PublishBatch -> PublishMultiple #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonWoolf
approved these changes
Apr 6, 2021
lmars
reviewed
Apr 6, 2021
| @@ -232,7 +232,7 @@ if err != nil { | |||
| } | |||
|
|
|||
| // You can also publish a batch of messages in a single request. | |||
| err = channel.PublishBatch(ctx, []*ably.Message{ | |||
| err = channel.PublishMultiple(ctx, []*ably.Message{ | |||
There was a problem hiding this comment.
Perhaps change the comment to "publish multiple messages" so not to confuse with a batch publish?
tcard
commented
Apr 12, 2021
tcard
force-pushed
the
feature/rename-publish-batch
branch
from
ae4f22d
to
30a6413
Compare
sacOO7
pushed a commit
that referenced
this pull request
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @SimonWoolf points out, there's an unrelated feature called batch publish already.