Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to canonical doc #556

Merged
merged 79 commits into from Jan 4, 2023
Merged

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Oct 10, 2022

@sacOO7 sacOO7 changed the title Marked existing doc comments as legacy Update to canonical doc Oct 24, 2022
@sacOO7 sacOO7 force-pushed the fix/add-canonical-docstring-comments branch from f7779b5 to 140b0a0 Compare November 20, 2022 15:07
@sacOO7 sacOO7 force-pushed the fix/add-canonical-docstring-comments branch from f69f421 to 7fecc24 Compare November 20, 2022 20:16
@sacOO7 sacOO7 force-pushed the fix/add-canonical-docstring-comments branch from 708a53d to 0f10f74 Compare November 20, 2022 22:25
@sacOO7 sacOO7 marked this pull request as ready for review November 20, 2022 22:28
README.md Outdated Show resolved Hide resolved
@sacOO7 sacOO7 force-pushed the fix/add-canonical-docstring-comments branch from 2606d7b to 6dade3d Compare November 25, 2022 20:21
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not reviewed the added API commentaries line by line because my understanding is that they're sourced from canonical references. I have one small suggestion and, of course, checks need to be green.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@Peter-Maguire Peter-Maguire self-requested a review January 3, 2023 17:12
@sacOO7 sacOO7 changed the base branch from integration/docs to main January 4, 2023 11:16
@QuintinWillison QuintinWillison merged commit 3d469dd into main Jan 4, 2023
@QuintinWillison QuintinWillison deleted the fix/add-canonical-docstring-comments branch January 4, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add/update docstring comments in Go SDK Add intro blurb to the Go static site generated
3 participants