New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to canonical doc #556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sacOO7
commented
Oct 10, 2022
•
edited
edited
- Fixes Add/update docstring comments in Go SDK #560
- Fixes Add intro blurb to the Go static site generated #558
- Related refactorings Refactored api-reference-doc sdk-api-reference#29
sacOO7
changed the title
Marked existing doc comments as legacy
Update to canonical doc
Oct 24, 2022
sacOO7
force-pushed
the
fix/add-canonical-docstring-comments
branch
from
November 20, 2022 15:07
f7779b5
to
140b0a0
Compare
sacOO7
force-pushed
the
fix/add-canonical-docstring-comments
branch
from
November 20, 2022 20:16
f69f421
to
7fecc24
Compare
sacOO7
force-pushed
the
fix/add-canonical-docstring-comments
branch
from
November 20, 2022 22:25
708a53d
to
0f10f74
Compare
amnonbc
reviewed
Nov 21, 2022
sacOO7
force-pushed
the
fix/add-canonical-docstring-comments
branch
from
November 25, 2022 20:21
2606d7b
to
6dade3d
Compare
QuintinWillison
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not reviewed the added API commentaries line by line because my understanding is that they're sourced from canonical references. I have one small suggestion and, of course, checks need to be green.
# Conflicts: # ably/auth.go # ably/proto_crypto.go # ably/proto_message.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.