Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against go 1.19, and drop support for 1.17 #563

Merged
merged 3 commits into from Nov 25, 2022
Merged

Conversation

amnonbc
Copy link
Contributor

@amnonbc amnonbc commented Nov 22, 2022

Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet to see what CI checks are failing and why... however I do wonder if this line in go.mod should also be modified as part of this change.

@amnonbc
Copy link
Contributor Author

amnonbc commented Nov 22, 2022

Yet to see what CI checks are failing and why...

go 1.19 slightly changes the output of gofmt
(in order to acomodate, links, markdown etc.)
So this occasionally changes the output of gofmt...

I can't really think of any fix other than removing this test, or only run it for go-1.19
and perhaps putting it back, once go 1.20 comes out and we have obsoleted 1.18
and run gofmt on everything (which is something I don't want to do while other folk have PRs in flight).

What do you think?
We do want to ensure that all code has passed gofmt,
but we have got to ensure that we support the the latest Go.

however I do wonder if this line in go.mod should also be modified as part of this change.

I don't think it matters, until we start using go-1.18 or 1.19 language features (e.g. Generics).

@QuintinWillison QuintinWillison merged commit fd6b938 into main Nov 25, 2022
@QuintinWillison QuintinWillison deleted the chore/go-1.19 branch November 25, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants