Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retry on cloudfront http errors #572

Merged
merged 4 commits into from Dec 16, 2022
Merged

feat: retry on cloudfront http errors #572

merged 4 commits into from Dec 16, 2022

Conversation

owenpearson
Copy link
Member

Resolves #571

@sacOO7
Copy link
Collaborator

sacOO7 commented Dec 13, 2022 •
edited

Also, it seems tests are failing.

QuintinWillison
QuintinWillison suggested changes Dec 15, 2022
View reviewed changes
ably/rest_client.go Outdated Show resolved Hide resolved
@QuintinWillison QuintinWillison merged commit 9ae4809 into main Dec 16, 2022
@QuintinWillison QuintinWillison deleted the fallback-on-cloudfront-error branch December 16, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmars lmars lmars approved these changes

@SimonWoolf SimonWoolf SimonWoolf approved these changes

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@stmoreau stmoreau stmoreau approved these changes

@sacOO7 sacOO7 sacOO7 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RSC15l4 (retry requests on Cloudfront HTTP error)
6 participants
@owenpearson @sacOO7 @lmars @SimonWoolf @QuintinWillison @stmoreau