Release/1.2.12 #600
Merged
Release/1.2.12 #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenpearson
requested changes
Jun 9, 2023
There was a problem hiding this comment.
I think we should editorialise the changelog entries a bit here:
- "Integration/subscription filters" is a bit cryptic
- Some of these entries aren't user facing so could be removed (eg. changing godocs base-url, msgpack test fixtures)
- Dropping support for go 1.18 should probably be closer to the top since users will probably want to be aware of that.
I'd actually be in favour of removing the "Closed issues" section since everything there is duplicated in "Merged pull requests"
Additionally, is it worth adding the same paragraph that we added to top of the ably-js release?
|
Thanks @owenpearson, updated. Will squash these last 2 commits before merge. |
owenpearson
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.