Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README for ablytest package usage #604

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Fix README for ablytest package usage #604

merged 4 commits into from
Jul 6, 2023

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Jun 27, 2023 •
edited
Loading

Fixed #602

@github-actions github-actions bot temporarily deployed to staging/pull/604/features June 27, 2023 18:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/604/godoc June 27, 2023 18:08 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/604/features June 27, 2023 18:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/604/godoc June 27, 2023 18:26 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review July 6, 2023 14:25
@github-actions github-actions bot temporarily deployed to staging/pull/604/features July 6, 2023 14:25 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/604/godoc July 6, 2023 14:26 Inactive
owenpearson
owenpearson requested changes Jul 6, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some spelling/grammar suggestions:

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sacOO7 @owenpearson
Apply suggestions from code review
e13bba4 
Co-authored-by: Owen Pearson <48608556+owenpearson@users.noreply.github.com>
@sacOO7 sacOO7 requested a review from owenpearson July 6, 2023 15:27
@sacOO7 sacOO7 merged commit fda113d into main Jul 6, 2023
5 of 8 checks passed
@sacOO7 sacOO7 deleted the update/ablytest-README branch July 6, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

@AndyTWF AndyTWF Awaiting requested review from AndyTWF

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update README for usage of ablytest package
2 participants
@sacOO7 @owenpearson