Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3746] Feature/integration 2.0 #613

Merged
merged 183 commits into from Jan 16, 2024
Merged

[SDK-3746] Feature/integration 2.0 #613

merged 183 commits into from Jan 16, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Jul 26, 2023 •
edited

@github-actions github-actions bot temporarily deployed to staging/pull/613/features July 26, 2023 18:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc July 26, 2023 18:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features July 26, 2023 19:23 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc July 26, 2023 19:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features July 26, 2023 19:48 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc July 26, 2023 19:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features July 27, 2023 18:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc July 27, 2023 18:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features July 27, 2023 18:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc July 27, 2023 18:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features July 28, 2023 15:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc July 28, 2023 15:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features July 28, 2023 16:06 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc July 28, 2023 16:06 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features July 28, 2023 16:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc July 28, 2023 16:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features July 28, 2023 16:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc July 28, 2023 16:29 Inactive
lmars
lmars reviewed Jan 13, 2024
View reviewed changes
ably/realtime_client.go Show resolved Hide resolved
ably/realtime_conn.go Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/613/features January 14, 2024 06:57 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc January 14, 2024 06:57 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features January 14, 2024 07:11 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc January 14, 2024 07:12 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/features January 15, 2024 06:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc January 15, 2024 06:37 Inactive
lmars
lmars approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@lmars lmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about logging the deprecation of RecoveryKey, otherwise LGTM

@github-actions github-actions bot temporarily deployed to staging/pull/613/features January 15, 2024 12:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc January 15, 2024 12:47 Inactive
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jan 15, 2024

One minor comment about logging the deprecation of RecoveryKey, otherwise LGTM

Okay, I have added warning message for the same 👍

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jan 16, 2024

Thanks both @ttypic and @lmars for the approval : )

@github-actions github-actions bot temporarily deployed to staging/pull/613/features January 16, 2024 07:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/613/godoc January 16, 2024 07:14 Inactive
@sacOO7 sacOO7 mentioned this pull request Jan 16, 2024
Open
@sacOO7 sacOO7 merged commit b4246f8 into main Jan 16, 2024
7 of 8 checks passed
@sacOO7 sacOO7 deleted the feature/integration-2.0 branch January 16, 2024 11:23
@sacOO7 sacOO7 self-assigned this Feb 6, 2024
@sacOO7 sacOO7 mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonWoolf SimonWoolf SimonWoolf left review comments

@lmars lmars lmars approved these changes

@ttypic ttypic ttypic approved these changes

Assignees

@sacOO7 sacOO7

Labels
None yet
Milestone
No milestone
4 participants
@sacOO7 @SimonWoolf @lmars @ttypic