Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep client default client read limit when realtime doesn't specify #631

Merged
merged 8 commits into from
Feb 2, 2024
Merged

fix: keep client default client read limit when realtime doesn't specify #631

merged 8 commits into from
Feb 2, 2024

Commits on Feb 1, 2024

  1. fix: keep client default client read limit when realtime doesn't specify 

    This is mostly for internal purposes, where we have rate limits of 0 (read: unlimited).

When 0 is received from realtime, the SDK should continue with its existing defaults.
    @AndyTWF
    AndyTWF committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c493707 View commit details
    Browse the repository at this point in the history

  2. test: use messagepipe

    @AndyTWF
    AndyTWF committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    514dd2f View commit details
    Browse the repository at this point in the history

  3. Update ably/realtime_channel_integration_test.go 

    Co-authored-by: sachin shinde <sachinshinde7676@gmail.com>
    @AndyTWF @sacOO7
    AndyTWF and sacOO7 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6ae052c View commit details
    Browse the repository at this point in the history

  4. Update ably/realtime_channel_integration_test.go 

    Co-authored-by: sachin shinde <sachinshinde7676@gmail.com>
    @AndyTWF @sacOO7
    AndyTWF and sacOO7 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f0184ad View commit details
    Browse the repository at this point in the history

  5. Update ably/realtime_channel_integration_test.go 

    Co-authored-by: sachin shinde <sachinshinde7676@gmail.com>
    @AndyTWF @sacOO7
    AndyTWF and sacOO7 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    39e5856 View commit details
    Browse the repository at this point in the history

  6. Implemented recursive unwrap for detecting websocketConn while settin… 

    …g connection readlimit
    @sacOO7
    sacOO7 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    acf4f81 View commit details
    Browse the repository at this point in the history

  7. Added test to check for default readlimit when server has no limit

    @sacOO7
    sacOO7 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    66a341b View commit details
    Browse the repository at this point in the history

  8. Refactored conn readlimit test when set by server

    @sacOO7
    sacOO7 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e85f788 View commit details
    Browse the repository at this point in the history