Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSA8f3 #402

Merged
merged 3 commits into from Apr 29, 2016
Merged

Fix RSA8f3 #402

merged 3 commits into from Apr 29, 2016

Conversation

ricardopereira
Copy link
Contributor

No description provided.

@tcard
Copy link
Contributor

tcard commented Apr 28, 2016

PTAL. I'm a bit unsure about this change as I've removed this explicit check from getClientId:

// Check wildcard
if ([self.tokenDetails.clientId isEqual:@"*"])
    // Any client
    return nil;

The commit that introduced that change (dd2baf0) mentions RSA15, but I don't see anything in RSA15 to justify that behavior, and the whole Auth test suite is passing after removing it.

@ricardopereira
Copy link
Contributor Author

Yes, you're right. I think it's good.

@tcard tcard merged commit 05965db into master Apr 29, 2016
@tcard tcard deleted the fix-rsa8f3 branch May 16, 2016 07:01
tcard pushed a commit that referenced this pull request May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants