Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosts class is not thread safe #650

Closed
jahlbornG opened this issue Feb 24, 2021 · 1 comment · Fixed by #657
Closed

Hosts class is not thread safe #650

jahlbornG opened this issue Feb 24, 2021 · 1 comment · Fixed by #657
Assignees
@QuintinWillison
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@jahlbornG
Copy link

jahlbornG commented Feb 24, 2021 •
edited by sync-by-unito bot

The Hosts class is used by various threads when making api calls, however, the internals of this class are not handled in a thread safe way. the various calls to manipulate the primary and preferred hosts and the expirations will not work correctly for more than one thread at a time.

┆Issue is synchronized with this Jira Bug by Unito
@QuintinWillison QuintinWillison self-assigned this Mar 2, 2021
@QuintinWillison QuintinWillison mentioned this issue Mar 2, 2021
Merged
@QuintinWillison QuintinWillison added the bug Something isn't working. It's clear that this does need to be fixed. label Mar 2, 2021
@QuintinWillison
Copy link
Contributor

Fixed in version 1.2.5, released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuintinWillison QuintinWillison

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makes the Hosts class safe to be called from any thread ably/ably-java
2 participants
@QuintinWillison @jahlbornG