Makes the Hosts class safe to be called from any thread#657
Merged
QuintinWillison merged 3 commits intomainfrom Mar 3, 2021
Merged
Makes the Hosts class safe to be called from any thread#657QuintinWillison merged 3 commits intomainfrom
QuintinWillison merged 3 commits intomainfrom
Conversation
paddybyers
approved these changes
Mar 3, 2021
| private final boolean fallbackHostsUseDefault; | ||
| private final long fallbackRetryTimeout; | ||
|
|
||
| private final Preferred preferred = new Preferred(); |
Member
There was a problem hiding this comment.
I'm a bit surprised you didn't go for the option of Preferred being immutable, with preferred non-final.
Contributor
Author
There was a problem hiding this comment.
Yeah, this was movement of state and the logic around mutating that state, as much for my own benefit to break the moving parts down a bit further... but, you're right, I could still have explored an immutable Preferred, as you say, with methods that return a new instance or the same instance as appropriate.
For speed of delivery right now I'm going to leave it as is but I appreciate the observation. 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #650.