Move force argument to AuthOptions as a variable #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Log.i("TokenAuth.authorise()", ""); | ||
| if(tokenDetails != null) { | ||
| if(tokenDetails.expires == 0 || tokenValid(tokenDetails)) { | ||
| if(!force) { | ||
| if(!options.force) { |
There was a problem hiding this comment.
Don't you need to check here that options != null ?
There was a problem hiding this comment.
I thought about that too, and decided not to take an action since test cases under RestAuthTest didn't failed. Now that, Travis reported RealtimeConnectFailTest's connect_token_expire_disconnected failing because of that reason, I will fix it now
gokhanbarisaker
force-pushed
the
authoptions-force
branch
from
c0f86a4
to
94e3790
Compare
gokhanbarisaker
force-pushed
the
authoptions-force
branch
from
94e3790
to
d9b0edf
Compare
|
LGTM |
1 similar comment
|
LGTM |
mattheworiordan
added a commit
that referenced
this pull request
Feb 29, 2016
Move force argument to AuthOptions as a variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #103